fix(spice): fix memory leak in executor pending receipts #14789
+80
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a race condition in which when block is being processed incoming receipts would be stored as pending but may never be processed. If block was already processed we would try applying it and would process receipts before detecting that it's already applied.
attila0x2A
changed the title
Contributor
Author
darioush
approved these changes
Jan 2, 2026
| simulate_single_outgoing_message(&mut actors, &message); | ||
| } | ||
| record_endorsements(&mut actors, &first_block); | ||
| let second_block = produce_block(&mut actors, &first_block); |
Contributor
There was a problem hiding this comment.
What's the role of second_block in this test?
Comment on lines
+213
to
+217
| // Some additional receipts can arrive after we have already started executing the block. (For | ||
| // example when we are tracking several shards for which we aren't chunk producer or we get | ||
| // receipts from different peers with different commitments in which case data distributor | ||
| // wouldn't know which is right.) In this case we want to make sure we process pending | ||
| // receipts to make sure don't leak memory by storing unverified receipts indefinitely. |
Contributor
There was a problem hiding this comment.
It seems to me that we could have receipts arrive after block in the case where the chunk producer is also requesting the missing data (i.e., receive receipts from pull & push path).
I didn't understand the part about tracking several shards.
Also to check my understanding, receiving data with different commitments, would not currently be possible since the distributor_actor has waiting_on_data and recently_decoded_data, but in the future it will be possible?
pugachAG
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a race condition in which when block is being processed incoming receipts would be stored as pending but may never be processed. If block was already processed we would try applying it and would process receipts before detecting that it's already applied.