refactor(spice): collect per-shard data once when applying chunks #14794
+133
−150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basically by collecting everything once we can avoid querying and computing the same information several times (like computing whether we should apply chunk or getting chunk extra). Also allows us to get rid of an expect for receipts existence. While at it I also change get_update_shard_job to use #[instrument]. This is a follow-up to near#14190 (comment)
attila0x2A
changed the title
darioush
approved these changes
Dec 17, 2025
Contributor
darioush
left a comment
darioush
left a comment
There was a problem hiding this comment.
As a side note we may need to re-introduce the mode parameter when handling syncing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically by collecting everything once we can avoid querying and computing the same information several times (like computing whether we should apply chunk or getting chunk extra).
Also allows us to get rid of an expect for receipts existence.
While at it I also change get_update_shard_job to use #[instrument].
This is a follow-up to
#14190 (comment)