Conversation
| "aws-smithy-http 0.62.5", | ||
| "aws-smithy-json 0.61.7", |
There was a problem hiding this comment.
It looks like there is a version mismatch between some sdks
There was a problem hiding this comment.
Maybe we should update everything
There was a problem hiding this comment.
But I can do it myself after the merge
| }; | ||
| } | ||
|
|
||
| instrument_secrets_manager_operation!(batch_get_secret_value); |
There was a problem hiding this comment.
So, we are not extracting any information from spans for ssm and secrets manager.
I'm not sure that would be correct...
Surely, there could be some useful metadata there.
| let attributes = attributes![Some("secretsmanager") | ||
| .as_attribute("cloud.service.name"),]; | ||
| SecretsManagerSpanBuilder::$op().attributes(attributes) |
There was a problem hiding this comment.
This looks like something that would be done in operations.
This file is intended for pre-operation instrumentation.
There was a problem hiding this comment.
Well, actually, it is already being sent as rpc.service. So cloud.service.name seems redundant to me.
| Self::client( | ||
| "SecretsManager", | ||
| method, | ||
| std::iter::empty::<crate::KeyValue>(), |
There was a problem hiding this comment.
Simply [] would work better here
2 participants
This pull request adds full support for AWS Secrets Manager and AWS Systems Manager (SSM) to the OpenTelemetry instrumentation crate. It introduces new feature flags, fluent builder instrumentation, and span builder implementations for these services, and updates documentation and feature bundles accordingly.
New AWS Service Instrumentation:
aws-secrets-managerandaws-ssmfeatures, including their dependencies inCargo.toml, and incorporated them into theaws-fullfeature bundle. [1] [2]src/middleware/aws/instrumentation/fluent_builder/secrets_manager.rs,src/middleware/aws/instrumentation/fluent_builder/ssm.rs) [1] [2]Span Builder Implementations:
SecretsManagerSpanBuilderandSsmSpanBuilderenums with methods for every supported operation, providing OpenTelemetry span builders for each AWS API call. (src/middleware/aws/operations/secrets_manager.rs,src/middleware/aws/operations/ssm.rs) [1] [2]src/middleware/aws/operations/mod.rs)Documentation Updates:
README.mdand crate-level docs to list Secrets Manager and SSM as fully supported AWS services. [1] [2]src/middleware/aws/instrumentation/fluent_builder/mod.rs)