Skip to content

Fix Gradle failure handling without System.exit - #8

Merged
Matyrobbrt merged 1 commit into
neoforged:mainfrom
mezz:pr/gradle-safe-fail
Aug 19, 2026
Merged

Fix Gradle failure handling without System.exit#8
Matyrobbrt merged 1 commit into
neoforged:mainfrom
mezz:pr/gradle-safe-fail

Conversation

@mezz

@mezz mezz commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

System.exit takes down the whole process, so for the gradle plugin it's nicer if we can return an error code on completion.

@Matyrobbrt Matyrobbrt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find exiting with a status code based on the number of incompatibilities weird and would rather have a simple state of success/failure, but it is an option which exists and I don't feel like removing it

@Matyrobbrt
Matyrobbrt merged commit 2f75ae1 into neoforged:main Aug 19, 2026
2 checks passed
@mezz
mezz deleted the pr/gradle-safe-fail branch August 19, 2026 14:51
@neoforged-releases

Copy link
Copy Markdown

🚀 This PR has been released as JarCompatibilityChecker version 0.1.19.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants