BUGFIX: Compare hosts when checking if target and source are the same #106
+20
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sebobo
requested changes
Feb 9, 2026
Member
Sebobo
left a comment
Sebobo
left a comment
There was a problem hiding this comment.
Thx for working on this!
Though this change doesn't look right yet to me. But I agree that it wasn't correct before.
| return $redirect->getSourceUriPath() === $sourceUriPath | ||
| && $redirect->getTargetUriPath() === $targetUriPath | ||
| && $redirect->getHost() === $host | ||
| && $redirect->getHost() === $targetHost |
Member
There was a problem hiding this comment.
The host is used to determine whether a redirect is triggered in the middleware. So it has no relation to the target. IMO this part of the change is incorrect.
I think rather the targetUriPath should be checked twice in case one time it was given without host and one time with a host.
| const parsedSourceUrl: URL = UrlUtil.parseURL(sourceUriPath, location.origin); | ||
| const parsedTargetUrl: URL = UrlUtil.parseURL(targetUriPath, location.origin); | ||
|
|
||
| if ((!host || host === parsedTargetUrl.host) && parsedSourceUrl.pathname === parsedTargetUrl.pathname) { |
Member
There was a problem hiding this comment.
Shouldn't it be instead:
if (parsedSourceUrl.hostname === parsedTargetUrl.hostname && parsedSourceUrl.pathname === parsedTargetUrl.pathname) {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the "sameSourceAndTarget" and check. Previously, it was not correctly comparing the source and target host.
On the frontend, it was comparing the sourceHost to the host the user is currently on:
if (!host || host === location.host) {This also had the unwanted side effect that this check would only work when the user is creating a redirect for the very same domain they are currently on (most of the time the primary site). When they were creating a redirect for another site, this would only be checked on the backend and give the user a generic error "Redirect could not be created".
And on the backend, it was creating the redirect using the
$hostvariable:$redirect = $this->redirectStorage->getOneBySourceUriPathAndHost($sourceUriPath, $host ?: null, false);and then comparing it against itself:
$isSame = $this->isSame($sourceUriPath, $targetUriPath, $host, $statusCode, $redirect);Example:
Domain: www.foo.bar
Source Path: test
Target Path: www.example.com/test
Before: This throws an error
Now: Works as expected