Skip to content

Conversation

@zhangsoledad
Copy link
Member

@zhangsoledad zhangsoledad commented Dec 9, 2025

What's Changed:

This PR fixes a series of logical issues in the tx-pool and block-template construction related to proposal transactions:

Prioritize proposal transactions
Proposals are now given the highest priority in the txpool.

Allow compact block recovery to use transactions from verify_queue
Compact-block reconstruction previously only searched the main pool, leading to unnecessary “missing transaction” failures when a proposal was already in verify_queue. The reconciler now checks pool_map, verify_queue, and the orphan set (when relevant).

Fix proposal selection logic in block template
The previous implementation had several severe bugs:

  • Not consider to exclude proposals whose content had already been included in previous blocks (re-proposing the same data).

Related changes

  • PR to update owner/repo:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Release note

Note: Add a note under the PR title in the release note.

@zhangsoledad zhangsoledad force-pushed the zhangsoledad/fix-txpool-proposal branch 2 times, most recently from e61a27e to e4018fc Compare December 11, 2025 12:52
@zhangsoledad zhangsoledad marked this pull request as ready for review December 11, 2025 13:06
@zhangsoledad zhangsoledad requested a review from a team as a code owner December 11, 2025 13:06
@zhangsoledad zhangsoledad requested review from quake and removed request for a team December 11, 2025 13:06
@zhangsoledad zhangsoledad force-pushed the zhangsoledad/fix-txpool-proposal branch from c715d19 to 72c2812 Compare December 24, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants