Skip to content

Conversation

@doitian
Copy link
Member

@doitian doitian commented Dec 24, 2025

What problem does this PR solve?

Problem Summary: The trigger is useless because the job condition is never true on
pushing events.

What is changed and how it works?

What's Changed: Remove the trigger

Check List

Tests

  • No code

Release note

None: Exclude this PR from the release note.

@doitian doitian requested a review from a team as a code owner December 24, 2025 02:23
@doitian doitian requested review from quake and removed request for a team December 24, 2025 02:23
@doitian doitian force-pushed the remove-useless-puhs-trigger-from-benchmark-workflow branch from a2b8d12 to 22ba68a Compare December 24, 2025 02:27
@doitian doitian added this pull request to the merge queue Dec 24, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 24, 2025
@doitian doitian added this pull request to the merge queue Dec 25, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 25, 2025
@doitian doitian added this pull request to the merge queue Dec 25, 2025
github-merge-queue bot pushed a commit that referenced this pull request Dec 25, 2025
…g] (#5070)

<!--
Thank you for contributing to nervosnetwork/ckb!

If you haven't already, please read
[CONTRIBUTING](https://github.com/nervosnetwork/ckb/blob/develop/CONTRIBUTING.md)
document.

If you're unsure about anything, just ask; somebody should be along to
answer within a day or two.

PR Title Format:
1. module [, module2, module3]: what's changed
2. *: what's changed
-->

### What problem does this PR solve?

Problem Summary: The trigger is useless because the job condition is
never true on
pushing events.

### What is changed and how it works?

What's Changed: Remove the trigger

### Check List <!--REMOVE the items that are not applicable-->

Tests <!-- At least one of them must be included. -->

- No code

### Release note <!-- Choose from None, Title Only and Note. Bugfixes or
new features need a release note. -->

```release-note
None: Exclude this PR from the release note.
```
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 25, 2025
@doitian doitian added this pull request to the merge queue Dec 25, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 25, 2025
@doitian doitian force-pushed the remove-useless-puhs-trigger-from-benchmark-workflow branch from 22ba68a to 8f4a9dd Compare December 27, 2025 14:20
@doitian doitian changed the title remove pkg/* branch push trigger from benchmark workflow [no-changelog] ci: remove pkg/* branch push trigger from benchmark workflow Dec 29, 2025
The trigger is useless because the job condition is never true on
pushing events.
@doitian doitian force-pushed the remove-useless-puhs-trigger-from-benchmark-workflow branch from 8f4a9dd to 0b500b3 Compare December 30, 2025 02:29
@doitian doitian enabled auto-merge December 30, 2025 02:31
@doitian doitian added this pull request to the merge queue Dec 30, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 30, 2025
@doitian doitian added this pull request to the merge queue Jan 4, 2026
Merged via the queue into nervosnetwork:develop with commit 285b13f Jan 4, 2026
17 checks passed
@doitian doitian deleted the remove-useless-puhs-trigger-from-benchmark-workflow branch January 5, 2026 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants