Fix invoice attribute, add back deprecated attribute and deny it in rpc #1023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjyr
force-pushed
the
fix-invoice-attribute
branch
2 times, most recently
from
50b70ee to
273a1e7
Compare
jjyr
force-pushed
the
fix-invoice-attribute
branch
from
273a1e7 to
6a1a477
Compare
chenyukang
approved these changes
Dec 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In https://github.com/nervosnetwork/fiber/pull/963/files#diff-e63edc2d81641a42647674f45d8ed3a68509e768102d5ec69f685996bbe79651 we delete the deprecated invoice attribute
FinalHtlcTimeoutWe add it back in the molecule types in https://github.com/nervosnetwork/fiber/pull/970/files , however it is not enough, we also need to add it back in inner types.
This PR:
FinalHtlcTimeoutInvoiceBuilderwe deny theFinalHtlcTimeout, so this attribute only works for legacy invoices