Conversation
|
Hi, thanks for this PR. Failures do not depend by this PR. I have some small changes to do to the CI, then I'll ask to rebase |
|
@basex please rebase, specs should pass |
|
done @tagliala Thanks |
|
All green, let me try if I remember how to run integration tests. Did you run it locally? |
|
Sorry, rabl needs some other changes that are not related to this PR. I will make the changes elsewhere and then ask to rebase or cherry-pick your commit to preserve your authoring |
|
Thanks, I've performed an integration test locally against rails 8 and it worked, however we now have two options
Point 2 would also apply as best practice for future PRs. It is required to have a single clean commit to merge here (I do not have the "rebase" feature available, maybe because it's the master branch on the remote fork) Please also add the following at the top of |
|
Discarding the commits in my fork automatically closed this MR. New PR from another branch here #768 |
Followed the same as #752
I tested locally and works without issues.
In the future if we stop supporting Rails 2 we can check for
Rails::VERSION::MAJOR. Example:Rails::VERSION::MAJOR > 6