Skip to content

sysbox-fs/seccomp: add CIFS/SMB3 mount proxy #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VitorRamos wants to merge 1 commit into
base: master
Choose a base branch
from
Open

sysbox-fs/seccomp: add CIFS/SMB3 mount proxy #118

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions seccomp/mount.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ func (m *mountSyscallInfo) process() (*sysResponse, error) {
return m.processSysMount(mip)
case "overlay":
return m.processOverlayMount(mip)
case "nfs":
case "nfs", "cifs", "smb3":
return m.processNfsMount(mip)
}
}
Expand Down Expand Up @@ -518,18 +518,18 @@ func (m *mountSyscallInfo) createOverlayMountPayload(
return &payload
}

// Method handles "nfs" mount syscall requests. Sysbox-fs does not manage nfs
// Method handles "nfs", "cifs", and "smb3" mount syscall requests. Sysbox-fs does not manage nfs
// mounts per-se, but only "proxies" the nfs mount syscall. It does this in
// order to enable nfs to be mounted from within a (non init) user-ns.
func (m *mountSyscallInfo) processNfsMount(
mip domain.MountInfoParserIface) (*sysResponse, error) {

logrus.Debugf("Processing new nfs mount: %v", m)
logrus.Debugf("Processing new %s mount: %v", m.FsType, m)

// Create instruction's payload.
payload := m.createNfsMountPayload(mip)
if payload == nil {
return nil, fmt.Errorf("Could not construct nfsMount payload")
return nil, fmt.Errorf("Could not construct %s mount payload", m.FsType)
}

// Create nsenter-event envelope; enter as true root to have required privileges.
Expand Down