Skip to content

bug: racing condition when setting isRestartInProgress #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
doromaraujo wants to merge 3 commits into
base: main
Choose a base branch
from
Open

bug: racing condition when setting isRestartInProgress #43

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ec6126e
Add value assingment to isRestarting and isRestartInProgress in the m…
doromaraujo Dec 18, 2025
60885a9
Apply navigation bar modifiers to the ZStack inside the NavigationView
doromaraujo Dec 18, 2025
f4fd16b
Bump version (0.0.14.16)
doromaraujo Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions NetBird/Source/App/Views/MainView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,9 +242,9 @@ struct MainView: View {
}
}
}
.navigationBarTitleDisplayMode(.inline)
.navigationBarHidden(true)
}
.navigationBarTitleDisplayMode(.inline)
.navigationBarHidden(true)
}
.navigationViewStyle(StackNavigationViewStyle())
}
Expand Down
7 changes: 5 additions & 2 deletions NetbirdNetworkExtension/PacketTunnelProvider.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,8 +216,11 @@ class PacketTunnelProvider: NEPacketTunnelProvider {
// Cancel timeout whether start succeeds or not
timeoutWorkItem.cancel()

self?.adapter.isRestarting = false
self?.isRestartInProgress = false
self?.monitorQueue.async {
self?.adapter.isRestarting = false
self?.isRestartInProgress = false
}

if let error = error {
AppLogger.shared.log("restartClient: start failed - \(error.localizedDescription)")
} else {
Expand Down
Loading