Fixes #19506: DCIM Filtering on Templates custom fields #20996
+218
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnovinger
requested review from
a team and
arthanson
and removed request for
a team
arthanson
requested changes
Dec 18, 2025
Collaborator
arthanson
left a comment
arthanson
left a comment
There was a problem hiding this comment.
I think you would probably want a DeviceComponentTemplateFilterForm that has device_type_id and module_type_id and have all these filter forms derive from that? For some of these you have device_type_id in the fieldset but you don't have them defined. I think you would want device_type_id and module_type_id on all of these filter forms?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #19506
Summary
Fixes issue #19506 by enabling filtering on DCIM template models’ custom fields and attributes.
Files Changed: filtersets.py.
Impact
UI/API filtering: Adds comprehensive filtering capabilities for template objects, aligning template-level filters with their concrete counterparts.
Scope: Form-layer changes; no schema or migrations implied.