Closes #20309: Add ASDOT notation support for ASN ranges #21004
+72
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces ASDOT notation for ASN Ranges to improve readability of large AS numbers. Adds `start_asdot` and `end_asdot` properties, columns, and display logic for ASN ranges in the UI. Fixes netbox-community#20309
jnovinger
requested review from
a team and
jeremystretch
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #20309
Introduces ASDOT notation for ASN ranges to improve readability of large AS numbers. Adds
start_asdotandend_asdotproperties, updates the relevant table columns, and adjusts display logic so ranges can show both ASPLAIN and ASDOT where appropriate.Note
To avoid repeating the same ASDOT conversion logic (
// 65536/% 65536) in multiple places, the conversion is implemented once asASNField.to_asdot()and reused by the model properties. This keeps the helper IPAM-scoped while ensuring consistent formatting across all ASN consumers.I also reordered methods/properties in
ASNRangeto follow the common NetBox model style for readability. If maintainers would prefer the simpler (more repetitive) inline conversion and/or don’t want the reordering, I’m happy to adjust.