fix: resolve agent hang on shutdown when stop signal sent during active scan#288
Merged
leoparente merged 2 commits intodevelopfrom Mar 12, 2026
Merged
Conversation
…ve scan Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Go test coverage
Total coverage: 59.6% |
jajeffries
reviewed
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the OTLP shutdown logic in the
orbAgentand improves the logging behavior in the OTLP bridge server. The main focus is on simplifying the shutdown process by removing unnecessary context passing and ensuring consistent logging.OTLP shutdown refactoring:
shutdownOTLPmethod inagent/agent.goto no longer require a context parameter, instead always using a background context with timeout. This simplifies shutdown calls and avoids potential nil context issues.shutdownOTLPinagent/agent.goto remove the context argument, ensuring consistency with the new method signature. [1] [2]Logging improvements:
agent/otlpbridge/server.gooutside the gRPC serving goroutine, so it always logs when the server starts, regardless of serve errors.