Conversation
…loses #231) Change the per_line_sub regex from ^!\s*$ to ^\s*!\s*$ so that bare ! lines at any indentation level are stripped during parsing, not just column-0 ones. Add tests covering the parse fix, remediation no-ops, and comment edge cases. Bump version to 3.5.1. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DuplicateChildErrorraised when parsing IOS-XR configs containing indented!section separators (e.g.,!,!) introduced in v3.5.0per_line_subregex^!\s*$only matched bare!at column 0; changed to^\s*!\s*$to match at any indentation level!separators vs intended without, intended with! commentvs running without, differing comment text), and a parsing edge case (trailing comment with no following sibling)Test plan
poetry run pytest tests/test_driver_cisco_xr.py tests/test_xr_comments.py -v— all 31 tests passpoetry run ./scripts/build.py lint-and-test— full lint + test suite passes with no issuesCloses #231
🤖 Generated with Claude Code