Ngstack 1017 schema processor #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emodric
reviewed
Jan 16, 2026
| new Reference('api_platform.openapi.factory.inner'), | ||
| new TaggedIteratorArgument( | ||
| tag: 'netgen_api_platform_extras.open_api_processor', | ||
| defaultPriorityMethod: 'getPriority', |
Member
There was a problem hiding this comment.
This will be deprecated in Symfony 8.1, so better not to use it here. Instead, we should sort the processors list in the factory class.
Check here for more info symfony/symfony#62339
and here on how I solved in Layouts netgen-layouts/layouts-core@e17483b (it's for default_index_method, but the principle applies)
emodric
reviewed
Jan 16, 2026
| final readonly class OpenApiFactory implements OpenApiFactoryInterface | ||
| { | ||
| /** | ||
| * @param iterable<OpenApiProcessorInterface> $processors |
emodric
reviewed
Jan 16, 2026
| use Symfony\Component\HttpKernel\Bundle\Bundle; | ||
|
|
||
| final class NetgenApiPlatformExtrasBundle extends Bundle {} | ||
| final class NetgenApiPlatformExtrasBundle extends Bundle |
Member
There was a problem hiding this comment.
This will need to be rebased as it will conflict once we merge #2 .
emodric
reviewed
Jan 16, 2026
| use ApiPlatform\OpenApi\OpenApi; | ||
| use Netgen\ApiPlatformExtras\OpenApi\Processor\OpenApiProcessorInterface; | ||
|
|
||
| final readonly class OpenApiFactory implements OpenApiFactoryInterface |
… api processor tag
…on and sort processors in factory
JakovKnezovicc
force-pushed
the
NGSTACK-1017-schema-processor
branch
from
309c473 to
27de09f
Compare
JakovKnezovicc
changed the base branch from
master
to
NGSTACK-1017-iri-template-generation
Base automatically changed from
NGSTACK-1017-iri-template-generation
to
master
January 19, 2026 12:40
emodric
reviewed
Jan 19, 2026
|
|
||
| $container->registerForAutoconfiguration(OpenApiProcessorInterface::class) | ||
| ->addTag('netgen_api_platform_extras.open_api_processor') | ||
| ->setLazy(true); |
Contributor
Author
There was a problem hiding this comment.
i prefer to use lazy but you are right to point out that it doesn't make sense here, all processors are iterated so we get no benefit of proxy service. Removed in 9c0e3c1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds mechanism for updating openapi spec by implementing custom processors that mutate openapi object in order of priority.
Included to container build if enabled as a feature in config passed via container parameter.