This repository was archived by the owner on Apr 27, 2023. It is now read-only.
BUG : return DHT_ERROR_CHECKSUM when temperature is negative.#1
Open
capswiz wants to merge 1 commit intonethoncho:masterfrom
Open
BUG : return DHT_ERROR_CHECKSUM when temperature is negative.#1capswiz wants to merge 1 commit intonethoncho:masterfrom
capswiz wants to merge 1 commit intonethoncho:masterfrom
Conversation
So I removed "currentTemperature &= 0x7FFF" line 208 and put "& 0x7FFF" in the expression line 209. Now it works with negative temperatures.
nethoncho
pushed a commit
that referenced
this pull request
Mar 25, 2013
Fix for DHT_ERROR_CHECKSUM with negative temperatures
Contributor
|
Suggested fix (from pull request) is not accurate for me because the unary minus will be performed before the & |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So I removed "currentTemperature &= 0x7FFF" line 208 and put "& 0x7FFF" in the expression line 209.
Now it works with negative temperatures.