Skip to content

build(types): improve type safety in parse-raw-flags #7839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
serhalp merged 1 commit into from
Jan 5, 2026
Merged

build(types): improve type safety in parse-raw-flags #7839

serhalp merged 1 commit into from
Jan 5, 2026
+3 −6

Conversation

@google-labs-jules
Copy link
Contributor

@google-labs-jules google-labs-jules bot commented Jan 3, 2026

This change improves the type safety in src/utils/parse-raw-flags.ts by replacing any with more specific types. This makes the code more robust and easier to maintain.

PR created automatically by Jules for task 2264802051269532956 started by @serhalp

@google-labs-jules
feat: improve type safety in parse-raw-flags
942ebef 
Improved the type safety in `src/utils/parse-raw-flags.ts` by replacing `any` with more specific types.

- `raw` is now `string[]`
- The return value of `parseRawFlags` is now `Record<string, unknown>`
- `value` in `aggressiveJSONParse` is now `string`
- The return value of `aggressiveJSONParse` is now `unknown`

These changes make the code more robust and easier to maintain.
@google-labs-jules
Copy link
Contributor Author

google-labs-jules bot commented Jan 3, 2026

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link

github-actions bot commented Jan 3, 2026

📊 Benchmark results

Comparing with a729259

  • Dependency count: 1,044 (no change)
  • Package size: 304 MB (no change)
  • Number of ts-expect-error directives: 375 ⬇️ 0.80% decrease vs. a729259

@serhalp serhalp changed the title Improve type safety in parse-raw-flags fix: improve type safety in parse-raw-flags Jan 5, 2026
@serhalp serhalp changed the title fix: improve type safety in parse-raw-flags build(types): improve type safety in parse-raw-flags Jan 5, 2026
@serhalp serhalp marked this pull request as ready for review January 5, 2026 15:10
@serhalp serhalp requested a review from a team as a code owner January 5, 2026 15:10
@serhalp serhalp enabled auto-merge (squash) January 5, 2026 15:11
@serhalp serhalp merged commit 300a568 into main Jan 5, 2026
138 of 142 checks passed
@serhalp serhalp deleted the fix/type-safety-parse-raw-flags-2264802051269532956 branch January 5, 2026 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhalp serhalp serhalp approved these changes

@VitaliyR VitaliyR VitaliyR approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@serhalp @VitaliyR