chore: remove framework adapters#703
Open
hrishikesh-k wants to merge 14 commits into
Open
Conversation
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughReorders root workspaces and adds a root-level TypeScript override; updates release-please workflow and README package table. Removes numerous nuxt-module and vite-plugin(-tanstack-start) playgrounds, fixtures, docs, and CI workflow files. Applies targeted runtime/test/typing changes across packages (functions registry event emissions, process/env helpers, WebSocket assignment, test typing, devDependencies, and small typing cleanups). Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@package.json`:
- Around line 5-28: The release-please package map in release-please-config.json
is out of sync with package.json workspaces: remove entries for the deleted
packages (e.g., packages/nuxt-module, packages/vite-plugin,
packages/vite-plugin-tanstack-start) or update their paths to match current
workspaces so release automation no longer targets non-existent paths; open
release-please-config.json, locate the package map section and delete or update
the corresponding keys to match the packages listed in package.json's
"workspaces" (ensure names and paths exactly match).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: c0632934-3afe-4826-853d-f5a83979c725
⛔ Files ignored due to path filters (8)
package-lock.jsonis excluded by!**/package-lock.jsonpackages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/public/android-chrome-192x192.pngis excluded by!**/*.pngpackages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/public/android-chrome-512x512.pngis excluded by!**/*.pngpackages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/public/apple-touch-icon.pngis excluded by!**/*.pngpackages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/public/favicon-16x16.pngis excluded by!**/*.pngpackages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/public/favicon-32x32.pngis excluded by!**/*.pngpackages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/public/favicon.icois excluded by!**/*.icopackages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/public/favicon.pngis excluded by!**/*.png
📒 Files selected for processing (92)
package.jsonpackages/nuxt-module/.gitignorepackages/nuxt-module/CHANGELOG.mdpackages/nuxt-module/README.mdpackages/nuxt-module/eslint.config.mjspackages/nuxt-module/nuxt.config.tspackages/nuxt-module/package.jsonpackages/nuxt-module/playground/.gitignorepackages/nuxt-module/playground/netlify/edge-functions/geo.tspackages/nuxt-module/playground/netlify/edge-functions/world-adder.tspackages/nuxt-module/playground/netlify/functions/hello.tspackages/nuxt-module/playground/nuxt.config.tspackages/nuxt-module/playground/package.jsonpackages/nuxt-module/playground/tsconfig.jsonpackages/nuxt-module/src/module.tspackages/nuxt-module/test/basic.test.tspackages/nuxt-module/test/fixtures/basic/.gitignorepackages/nuxt-module/test/fixtures/basic/app.vuepackages/nuxt-module/test/fixtures/basic/nuxt.config.tspackages/nuxt-module/test/fixtures/basic/package.jsonpackages/nuxt-module/test/fixtures/with-functions/.gitignorepackages/nuxt-module/test/fixtures/with-functions/app.vuepackages/nuxt-module/test/fixtures/with-functions/netlify/edge-functions/geo.tspackages/nuxt-module/test/fixtures/with-functions/netlify/edge-functions/world-adder.tspackages/nuxt-module/test/fixtures/with-functions/netlify/functions/hello.tspackages/nuxt-module/test/fixtures/with-functions/nuxt.config.tspackages/nuxt-module/test/fixtures/with-functions/package.jsonpackages/nuxt-module/test/functions.test.tspackages/nuxt-module/tsconfig.jsonpackages/vite-plugin-tanstack-start/.gitignorepackages/vite-plugin-tanstack-start/CHANGELOG.mdpackages/vite-plugin-tanstack-start/README.mdpackages/vite-plugin-tanstack-start/package.jsonpackages/vite-plugin-tanstack-start/src/main.tspackages/vite-plugin-tanstack-start/test/e2e/build.test.tspackages/vite-plugin-tanstack-start/test/e2e/dev.test.tspackages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/.gitignorepackages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/.prettierignorepackages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/README.mdpackages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/netlify.tomlpackages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/package.jsonpackages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/public/site.webmanifestpackages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/components/Counter.tsxpackages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/components/DefaultCatchBoundary.tsxpackages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/components/NotFound.tsxpackages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/components/PostError.tsxpackages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/components/UserError.tsxpackages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/routeTree.gen.tspackages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/router.tsxpackages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/routes/__root.tsxpackages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/routes/_pathlessLayout.tsxpackages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/routes/_pathlessLayout/_nested-layout.tsxpackages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/routes/_pathlessLayout/_nested-layout/route-a.tsxpackages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/routes/_pathlessLayout/_nested-layout/route-b.tsxpackages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/routes/api/users.$userId.tspackages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/routes/api/users.tspackages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/routes/customScript[.]js.tspackages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/routes/deferred.tsxpackages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/routes/index.tsxpackages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/routes/posts.$postId.tsxpackages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/routes/posts.index.tsxpackages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/routes/posts.tsxpackages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/routes/posts_.$postId.deep.tsxpackages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/routes/redirect.tsxpackages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/routes/rsc-basic.tsxpackages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/routes/rsc-composite.tsxpackages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/routes/users.$userId.tsxpackages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/routes/users.index.tsxpackages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/routes/users.tsxpackages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/styles/app.csspackages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/utils/loggingMiddleware.tsxpackages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/utils/posts.tsxpackages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/utils/rsc.tsxpackages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/utils/seo.tspackages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/utils/users.tsxpackages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/tsconfig.jsonpackages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/vite.config.tspackages/vite-plugin-tanstack-start/test/support/netlify-deploy.tspackages/vite-plugin-tanstack-start/tsconfig.jsonpackages/vite-plugin-tanstack-start/tsup.config.tspackages/vite-plugin-tanstack-start/vitest.config.tspackages/vite-plugin/.gitignorepackages/vite-plugin/CHANGELOG.mdpackages/vite-plugin/README.mdpackages/vite-plugin/package.jsonpackages/vite-plugin/src/lib/build.tspackages/vite-plugin/src/lib/logger.tspackages/vite-plugin/src/main.test.tspackages/vite-plugin/src/main.tspackages/vite-plugin/tsconfig.jsonpackages/vite-plugin/tsup.config.tspackages/vite-plugin/vitest.config.ts
💤 Files with no reviewable changes (91)
- packages/vite-plugin-tanstack-start/.gitignore
- packages/vite-plugin/README.md
- packages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/styles/app.css
- packages/nuxt-module/test/fixtures/with-functions/netlify/functions/hello.ts
- packages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/routes/_pathlessLayout/_nested-layout/route-b.tsx
- packages/vite-plugin/tsup.config.ts
- packages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/routes/redirect.tsx
- packages/nuxt-module/test/fixtures/with-functions/.gitignore
- packages/vite-plugin-tanstack-start/src/main.ts
- packages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/routes/_pathlessLayout.tsx
- packages/vite-plugin-tanstack-start/tsconfig.json
- packages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/tsconfig.json
- packages/nuxt-module/CHANGELOG.md
- packages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/routes/_pathlessLayout/_nested-layout.tsx
- packages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/utils/rsc.tsx
- packages/nuxt-module/playground/package.json
- packages/vite-plugin-tanstack-start/vitest.config.ts
- packages/nuxt-module/playground/netlify/edge-functions/geo.ts
- packages/nuxt-module/test/fixtures/basic/.gitignore
- packages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/README.md
- packages/vite-plugin-tanstack-start/tsup.config.ts
- packages/nuxt-module/playground/netlify/functions/hello.ts
- packages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/routes/customScript[.]js.ts
- packages/nuxt-module/test/fixtures/with-functions/app.vue
- packages/vite-plugin/src/main.test.ts
- packages/nuxt-module/playground/nuxt.config.ts
- packages/vite-plugin/.gitignore
- packages/vite-plugin/package.json
- packages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/utils/seo.ts
- packages/vite-plugin/CHANGELOG.md
- packages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/components/Counter.tsx
- packages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/routes/posts.index.tsx
- packages/vite-plugin/vitest.config.ts
- packages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/routes/_pathlessLayout/_nested-layout/route-a.tsx
- packages/nuxt-module/tsconfig.json
- packages/nuxt-module/test/fixtures/with-functions/netlify/edge-functions/world-adder.ts
- packages/vite-plugin-tanstack-start/README.md
- packages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/routes/__root.tsx
- packages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/components/PostError.tsx
- packages/nuxt-module/test/fixtures/with-functions/package.json
- packages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/vite.config.ts
- packages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/components/UserError.tsx
- packages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/routes/deferred.tsx
- packages/nuxt-module/src/module.ts
- packages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/routes/posts.$postId.tsx
- packages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/router.tsx
- packages/nuxt-module/test/fixtures/basic/app.vue
- packages/vite-plugin/src/lib/build.ts
- packages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/utils/posts.tsx
- packages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/.gitignore
- packages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/components/NotFound.tsx
- packages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/routes/api/users.$userId.ts
- packages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/public/site.webmanifest
- packages/vite-plugin-tanstack-start/package.json
- packages/nuxt-module/eslint.config.mjs
- packages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/utils/users.tsx
- packages/vite-plugin-tanstack-start/CHANGELOG.md
- packages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/utils/loggingMiddleware.tsx
- packages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/routes/users.$userId.tsx
- packages/nuxt-module/test/basic.test.ts
- packages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/routes/rsc-composite.tsx
- packages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/routeTree.gen.ts
- packages/nuxt-module/README.md
- packages/nuxt-module/test/functions.test.ts
- packages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/.prettierignore
- packages/nuxt-module/playground/.gitignore
- packages/nuxt-module/test/fixtures/basic/nuxt.config.ts
- packages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/routes/index.tsx
- packages/vite-plugin/src/main.ts
- packages/nuxt-module/test/fixtures/with-functions/nuxt.config.ts
- packages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/package.json
- packages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/routes/rsc-basic.tsx
- packages/vite-plugin-tanstack-start/test/e2e/dev.test.ts
- packages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/routes/users.tsx
- packages/vite-plugin/tsconfig.json
- packages/nuxt-module/playground/netlify/edge-functions/world-adder.ts
- packages/nuxt-module/test/fixtures/basic/package.json
- packages/nuxt-module/.gitignore
- packages/nuxt-module/playground/tsconfig.json
- packages/vite-plugin-tanstack-start/test/e2e/build.test.ts
- packages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/routes/users.index.tsx
- packages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/routes/posts_.$postId.deep.tsx
- packages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/components/DefaultCatchBoundary.tsx
- packages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/routes/api/users.ts
- packages/vite-plugin-tanstack-start/test/support/netlify-deploy.ts
- packages/vite-plugin/src/lib/logger.ts
- packages/nuxt-module/test/fixtures/with-functions/netlify/edge-functions/geo.ts
- packages/nuxt-module/nuxt.config.ts
- packages/nuxt-module/package.json
- packages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/src/routes/posts.tsx
- packages/vite-plugin-tanstack-start/test/fixtures/start-basic-rc/netlify.toml
Contributor
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
release-please-config.json (1)
8-41:⚠️ Potential issue | 🟠 Major | ⚡ Quick winRetire the publish workflow with these package removals.
Dropping
packages/vite-pluginandpackages/vite-plugin-tanstack-startfromrelease-please-config.jsonstops release-please from creating their--release_createdoutputs, but.github/workflows/release-please.yaml:254-275still hasworkflow_dispatchbranches that publish both packages unconditionally. That leaves a manual path to ship adapters this PR is trying to retire. Please remove or explicitly disable those publish steps in the same change.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@release-please-config.json` around lines 8 - 41, The release config removed packages/vite-plugin and packages/vite-plugin-tanstack-start, but the release workflow still contains unconditional publish steps for those adapters; update the workflow_dispatch publish branches (the workflow job(s) that run the "publish" or "dispatch" steps for vite-plugin and vite-plugin-tanstack-start) to either remove those publish steps or explicitly disable them (e.g., gate by a conditional or remove the job/step) so release-please can no longer be triggered manually to publish those packages; locate the publish job names or step ids referencing vite-plugin and vite-plugin-tanstack-start in the release workflow and remove or wrap them with a false/disabled condition.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@release-please-config.json`:
- Around line 8-41: The release config removed packages/vite-plugin and
packages/vite-plugin-tanstack-start, but the release workflow still contains
unconditional publish steps for those adapters; update the workflow_dispatch
publish branches (the workflow job(s) that run the "publish" or "dispatch" steps
for vite-plugin and vite-plugin-tanstack-start) to either remove those publish
steps or explicitly disable them (e.g., gate by a conditional or remove the
job/step) so release-please can no longer be triggered manually to publish those
packages; locate the publish job names or step ids referencing vite-plugin and
vite-plugin-tanstack-start in the release workflow and remove or wrap them with
a false/disabled condition.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 7a9aca4d-e6e0-4e7e-a7b6-904e7a0b0307
📒 Files selected for processing (1)
release-please-config.json
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
README.md (1)
30-49:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winFix README formatting to satisfy Prettier check.
CI is currently failing on
README.mdformatting (Check formatting / formatand0_format.txt). Please run Prettier on this file and commit the result.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@README.md` around lines 30 - 49, The README.md table is failing the Prettier formatting check; run Prettier (or your repo's format script) on README.md to reformat the package listing table (including rows like `@netlify/database`, `@netlify/edge-functions`, `@netlify/identity`) so it matches project formatting rules, then commit the updated README to satisfy the "Check formatting / format" CI job.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@README.md`:
- Line 36: Replace the HTML comment placeholders ("<!-- TODO description -->")
in the packages table with concrete package descriptions for each listed package
(e.g., replace the placeholder for `@netlify/database` and the other package rows
referenced) so the README presents real, user-facing summaries; update the cell
content for the packages table entries (the second column) to short, clear
descriptions that match the package names (e.g., `@netlify/database` → "Netlify
database client for local and remote data storage") and do the same for the rows
at the other referenced positions.
---
Outside diff comments:
In `@README.md`:
- Around line 30-49: The README.md table is failing the Prettier formatting
check; run Prettier (or your repo's format script) on README.md to reformat the
package listing table (including rows like `@netlify/database`,
`@netlify/edge-functions`, `@netlify/identity`) so it matches project formatting
rules, then commit the updated README to satisfy the "Check formatting / format"
CI job.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
Contributor
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/dev/src/lib/env.ts (1)
60-66:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winKeep the defensive defaults on these exported helpers.
Removing these defaults turns previously harmless omissions into runtime
TypeErrors for JS/untyped callers (Object.entries(variables)andenvelopeItems.filter(...)). Restoring the fallbacks preserves the old runtime behavior without changing the TypeScript contract.Suggested patch
export const injectEnvVariables = async ({ accountSlug, - baseVariables, + baseVariables = {}, envAPI, netlifyAPI, siteID, }: InjectEnvironmentVariablesOptions) => { @@ export const formatEnvelopeData = ({ context = 'dev', - envelopeItems, + envelopeItems = [], scope = 'any', source, }: {Also applies to: 263-270
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/dev/src/lib/env.ts` around lines 60 - 66, The exported helper injectEnvVariables (and the other exported helper that operates on envelopeItems) removed defensive defaults which causes runtime TypeErrors for untyped callers; restore safe defaults by updating function parameter defaults—e.g. in injectEnvVariables set baseVariables = {} and any optional API params (envAPI, netlifyAPI) to {} (and siteID to '' if applicable), and in the other helper set variables = {} or envelopeItems = [] as needed—so calls to Object.entries(variables) and envelopeItems.filter(...) are safe for JS/untyped callers while keeping the TypeScript signatures unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@packages/dev/src/lib/env.ts`:
- Around line 60-66: The exported helper injectEnvVariables (and the other
exported helper that operates on envelopeItems) removed defensive defaults which
causes runtime TypeErrors for untyped callers; restore safe defaults by updating
function parameter defaults—e.g. in injectEnvVariables set baseVariables = {}
and any optional API params (envAPI, netlifyAPI) to {} (and siteID to '' if
applicable), and in the other helper set variables = {} or envelopeItems = [] as
needed—so calls to Object.entries(variables) and envelopeItems.filter(...) are
safe for JS/untyped callers while keeping the TypeScript signatures unchanged.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 65095cc9-32e3-4822-a708-ebabd6c4dd4e
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (13)
.github/workflows/nuxt-module.yamlREADME.mdpackage.jsonpackages/database/prod/src/main.test.tspackages/database/prod/src/main.tspackages/dev-utils/src/lib/process.tspackages/dev/src/lib/env.tspackages/functions/dev/src/registry.tspackages/functions/dev/src/runtimes/nodejs/builder.tspackages/functions/dev/src/runtimes/nodejs/config.tspackages/functions/prod/src/lib/system_logger.test.tspackages/identity/prod/package.jsonpackages/otel/src/exporters/netlify.ts
💤 Files with no reviewable changes (2)
- packages/identity/prod/package.json
- .github/workflows/nuxt-module.yaml
✅ Files skipped from review due to trivial changes (4)
- packages/otel/src/exporters/netlify.ts
- packages/functions/prod/src/lib/system_logger.test.ts
- packages/database/prod/src/main.test.ts
- packages/database/prod/src/main.ts
serhalp
requested changes
Jun 15, 2026
serhalp
left a comment
serhalp
left a comment
Member
There was a problem hiding this comment.
LGTM, other than the package.json#workspaces issue!
serhalp
approved these changes
Jun 16, 2026
serhalp
left a comment
serhalp
left a comment
Member
There was a problem hiding this comment.
LGTM. but let's make sure the framework-adapters repo is fully configured and confirmed to be able to publish the packages before merging this one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
context: https://netlify.slack.com/archives/C01TKAEBP3Q/p1780300800170089
notable changes apart from deleting the packages and updating the readme:
typescript-eslint. tsup currrently doesn't support it: DTS Build error TS5101: Option 'baseUrl' is deprecated and will stop functioning in TypeScript 7.0. egoist/tsup#1388, so pinning to 5 was the best step.