NETOBSERV-2575: allow setting toleration for static plugin#2793
Open
jotak wants to merge 2 commits into
Open
Conversation
Collaborator
|
@jotak: This pull request references NETOBSERV-2575 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target either version "5.0." or "openshift-5.0.", but it targets "netobserv-1.12.1" instead. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedToo many files! This PR contains 200 files, which is 50 over the limit of 150. To get a review, narrow the scope: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (200)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
jotak
commented
Jun 8, 2026
| } | ||
|
|
||
| func readConfigFromEnv(c *manager.Config) { | ||
| c.StaticPluginConfig = manager.StaticPluginConfig{ |
Member
Author
There was a problem hiding this comment.
team / @jpinsonneau : I'm thinking about generalizing this approach, of reading directly config from env, rather than through command line arguments in the operator. In the YAML, instead of having this pattern "ENV => command line injection => code reads from command line", we'd just have "ENV => code reads from env", so a little bit simpler.
wdyt? do you think we're losing something in not driving that through args?
Member
There was a problem hiding this comment.
That's probably cleaner. We just need to ensure it doesn't break any tests / CI runs that would pass args directly without setting the ENVs.
Also, if you plan to replace existing args, we need to handle defaults properly.
Member
Author
There was a problem hiding this comment.
yes, ok. I'll leave this PR just as that a prepare a refactoring in another one
New env "STATIC_PLUGIN_INHERITED_TOLERATION_SUBSCRIPTION", to provide the name of the subscription resource to inherit toleration config from. Also propagate node selector and affinity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
New env "STATIC_PLUGIN_INHERITED_TOLERATION_SUBSCRIPTION", to provide the name of the subscription resource to inherit toleration config from.
Also propagate node selector and affinity
Dependencies
n/a
Checklist