Skip to content

Conversation

@cbaker6
Copy link
Member

@cbaker6 cbaker6 commented Dec 9, 2025

There are build challenges on Swift 6.x on Linux, and many of the dependencies' latest versions require 6.x, but didn't mark these as major version releases. Therefore, this PR locks down the last versions that work on the Linux 5.10 image. Related to #78

If you are still having build issues, delete your Package.resolved file and let it regenerate based on the Package.resolved file in this repo. Note that all dependencies must work with Swift 5.10 and cannot require a higher version.

@coderabbitai
Copy link

coderabbitai bot commented Dec 9, 2025

Warning

Rate limit exceeded

@cbaker6 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 4 minutes and 42 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 52288dc and b4caa25.

📒 Files selected for processing (2)
  • .github/workflows/ci.yml (4 hunks)
  • .github/workflows/release.yml (1 hunks)
📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated Swift tools version support from 5.7 to 5.10
    • Upgraded Vapor and core dependencies to latest stable versions
    • Updated Parse server image to version 8.5.0
    • Updated build infrastructure to Xcode 16.4

✏️ Tip: You can customize this high-level summary in your review settings.

Walkthrough

A broad dependency and lockfile refresh, new exact-version package pins added, CI Xcode path bumps to 16.4, Docker parse image updated to 8.5.0-dashboard, and an internal static Parse.configuration changed to nonisolated(unsafe) to alter isolation semantics.

Changes

Cohort / File(s) Summary
Dependency lockfile
Package.resolved
Large lockfile update: many dependency revisions/versions bumped; several new remote packages added (Apple and Swift Server libs); URL/location normalization (some .git suffixes added).
Package manifest
Package.swift
Swift tools bumped 5.7 → 5.10; Vapor changed to exact 4.117.2; Parse‑Swift bumped to 5.12.3; added exact-version package dependencies (swift-collections, swift-nio, swift-nio-http2, swift-log, swift-nio-ssl, swift-crypto, async-http-client, swift-nio-extras, swift-asn1, swift-async-algorithms, swift-certificates, swift-http-structured-headers, swift-nio-transport-services).
CI / Release workflows
.github/workflows/ci.yml, .github/workflows/release.yml
CI Xcode developer path updated from /Applications/Xcode_16.2.app/.../Applications/Xcode_16.4.app/... (CI_XCODE / DEVELOPER_DIR). No step logic changes.
Internal concurrency tweak
Sources/ParseServerSwift/Parse.swift
Changed internal static property declaration: static var configuration: ParseServerConfiguration!nonisolated(unsafe) static var configuration: ParseServerConfiguration! (alters actor isolation semantics).
Docker
docker-compose.yml
Updated parse service image tag from 8.0.1-dashboard8.5.0-dashboard.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

  • Inspect API compatibility impacts from Vapor/Parse‑Swift and core Swift packages.
  • Review the use and safety of nonisolated(unsafe) on Parse.configuration.
  • Spot-check transitive dependency bumps in Package.resolved.
  • Confirm CI Xcode path and macOS/toolchain expectations.

Poem

PLUS ULTRA! ⚡
Versions rise and toolchains climb,
Xcode tuned, deps in time,
A safety tweak, a docker tag to show,
Push onward now — code’s ready to go!

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and concisely describes the main objective—pinning all dependencies to work with Swift 5.10.
Description check ✅ Passed The description is directly related to the changeset, explaining the rationale for pinning dependencies to Swift 5.10 compatibility.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 35.77%. Comparing base (c5d5b5c) to head (b4caa25).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
- Coverage   37.93%   35.77%   -2.16%     
==========================================
  Files          11       11              
  Lines        1189      970     -219     
==========================================
- Hits          451      347     -104     
+ Misses        738      623     -115     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cbaker6 cbaker6 changed the title fix: Update Vapor to 4.119.2 fix: Update Vapor to 4.117.2 Dec 9, 2025
@cbaker6
Copy link
Member Author

cbaker6 commented Dec 10, 2025

@coderabbitai please review again

@coderabbitai
Copy link

coderabbitai bot commented Dec 10, 2025

@cbaker6: PLUS ULTRA! 💪⚡

I shall review these changes with the spirit of a true hero! Your dependency updates and Xcode version bump shall be examined with the utmost care and attention!

Stand by, young hero – the review is underway! 🦸‍♂️✨

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@cbaker6 cbaker6 changed the title fix: Update Vapor to 4.117.2 fix: Cap all dependencies to work on Swift 5.10 image Dec 10, 2025
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7aabf5b and 87f8504.

📒 Files selected for processing (3)
  • Package.resolved (1 hunks)
  • Package.swift (1 hunks)
  • docker-compose.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: docs
  • GitHub Check: linux
  • GitHub Check: spm-test
🔇 Additional comments (1)
docker-compose.yml (1)

83-96: Parse HIPAA image bump looks solid—confirm compatibility, young hero!

The move to netreconlab/parse-hipaa:8.5.0-dashboard keeps your stack in step with the wider dependency refresh and is a good, explicit tag choice for reproducible deployments. Please double‑check that this image version doesn’t introduce schema changes, env var tweaks, or dashboard auth changes that require matching updates in your config and database migrations. Plus Ultra!

Comment on lines +8 to 262
"revision" : "efb14fec9f79f3f8d4f2a6c0530303efb6fe6533",
"version" : "1.29.1"
}
},
{
"identity" : "async-kit",
"kind" : "remoteSourceControl",
"location" : "https://github.com/vapor/async-kit.git",
"state" : {
"revision" : "7ece208cd401687641c88367a00e3ea2b04311f1",
"version" : "1.19.0"
"revision" : "6f3615ccf2ac3c2ae0c8087d527546e9544a43dd",
"version" : "1.21.0"
}
},
{
"identity" : "console-kit",
"kind" : "remoteSourceControl",
"location" : "https://github.com/vapor/console-kit.git",
"state" : {
"revision" : "9f7932f22ab6f64aafadc14491e694179b7d0f6f",
"version" : "4.14.3"
"revision" : "742f624a998cba2a9e653d9b1e91ad3f3a5dff6b",
"version" : "4.15.2"
}
},
{
"identity" : "multipart-kit",
"kind" : "remoteSourceControl",
"location" : "https://github.com/vapor/multipart-kit.git",
"state" : {
"revision" : "a31236f24bfd2ea2f520a74575881f6731d7ae68",
"version" : "4.7.0"
"revision" : "3498e60218e6003894ff95192d756e238c01f44e",
"version" : "4.7.1"
}
},
{
"identity" : "parse-swift",
"kind" : "remoteSourceControl",
"location" : "https://github.com/netreconlab/Parse-Swift.git",
"state" : {
"revision" : "7a06604443662204d1d9a38a7307a8c42c8d1d6c",
"version" : "5.12.0"
"revision" : "12b8e752a21d53769b39441d02ff03261edecec8",
"version" : "5.12.3"
}
},
{
"identity" : "routing-kit",
"kind" : "remoteSourceControl",
"location" : "https://github.com/vapor/routing-kit.git",
"state" : {
"revision" : "8c9a227476555c55837e569be71944e02a056b72",
"version" : "4.9.1"
"revision" : "1a10ccea61e4248effd23b6e814999ce7bdf0ee0",
"version" : "4.9.3"
}
},
{
"identity" : "swift-algorithms",
"kind" : "remoteSourceControl",
"location" : "https://github.com/apple/swift-algorithms.git",
"state" : {
"revision" : "f6919dfc309e7f1b56224378b11e28bab5bccc42",
"version" : "1.2.0"
"revision" : "87e50f483c54e6efd60e885f7f5aa946cee68023",
"version" : "1.2.1"
}
},
{
"identity" : "swift-asn1",
"kind" : "remoteSourceControl",
"location" : "https://github.com/apple/swift-asn1.git",
"state" : {
"revision" : "f70225981241859eb4aa1a18a75531d26637c8cc",
"version" : "1.4.0"
}
},
{
"identity" : "swift-async-algorithms",
"kind" : "remoteSourceControl",
"location" : "https://github.com/apple/swift-async-algorithms.git",
"state" : {
"revision" : "042e1c4d9d19748c9c228f8d4ebc97bb1e339b0b",
"version" : "1.0.4"
}
},
{
"identity" : "swift-atomics",
"kind" : "remoteSourceControl",
"location" : "https://github.com/apple/swift-atomics.git",
"state" : {
"revision" : "cd142fd2f64be2100422d658e7411e39489da985",
"version" : "1.2.0"
"revision" : "b601256eab081c0f92f059e12818ac1d4f178ff7",
"version" : "1.3.0"
}
},
{
"identity" : "swift-certificates",
"kind" : "remoteSourceControl",
"location" : "https://github.com/apple/swift-certificates.git",
"state" : {
"revision" : "c399f90e7bbe8874f6cbfda1d5f9023d1f5ce122",
"version" : "1.15.1"
}
},
{
"identity" : "swift-collections",
"kind" : "remoteSourceControl",
"location" : "https://github.com/apple/swift-collections.git",
"state" : {
"revision" : "3d2dc41a01f9e49d84f0a3925fb858bed64f702d",
"version" : "1.1.2"
"revision" : "c11818f3cae0780656baa430b49e7f163f08dffd",
"version" : "1.1.6"
}
},
{
"identity" : "swift-crypto",
"kind" : "remoteSourceControl",
"location" : "https://github.com/apple/swift-crypto.git",
"state" : {
"revision" : "46072478ca365fe48370993833cb22de9b41567f",
"version" : "3.5.2"
"revision" : "95ba0316a9b733e92bb6b071255ff46263bbe7dc",
"version" : "3.15.1"
}
},
{
"identity" : "swift-distributed-tracing",
"kind" : "remoteSourceControl",
"location" : "https://github.com/apple/swift-distributed-tracing.git",
"state" : {
"revision" : "a64a0abc2530f767af15dd88dda7f64d5f1ff9de",
"version" : "1.2.0"
"revision" : "baa932c1336f7894145cbaafcd34ce2dd0b77c97",
"version" : "1.3.1"
}
},
{
"identity" : "swift-http-structured-headers",
"kind" : "remoteSourceControl",
"location" : "https://github.com/apple/swift-http-structured-headers.git",
"state" : {
"revision" : "d01361d32e14ae9b70ea5bd308a3794a198a2706",
"version" : "1.2.0"
"revision" : "1625f271afb04375bf48737a5572613248d0e7a0",
"version" : "1.4.0"
}
},
{
"identity" : "swift-http-types",
"kind" : "remoteSourceControl",
"location" : "https://github.com/apple/swift-http-types",
"location" : "https://github.com/apple/swift-http-types.git",
"state" : {
"revision" : "ae67c8178eb46944fd85e4dc6dd970e1f3ed6ccd",
"version" : "1.3.0"
"revision" : "45eb0224913ea070ec4fba17291b9e7ecf4749ca",
"version" : "1.5.1"
}
},
{
"identity" : "swift-log",
"kind" : "remoteSourceControl",
"location" : "https://github.com/apple/swift-log.git",
"state" : {
"revision" : "9cb486020ebf03bfa5b5df985387a14a98744537",
"version" : "1.6.1"
"revision" : "ce592ae52f982c847a4efc0dd881cc9eb32d29f2",
"version" : "1.6.4"
}
},
{
"identity" : "swift-metrics",
"kind" : "remoteSourceControl",
"location" : "https://github.com/apple/swift-metrics.git",
"state" : {
"revision" : "e0165b53d49b413dd987526b641e05e246782685",
"version" : "2.5.0"
"revision" : "0743a9364382629da3bf5677b46a2c4b1ce5d2a6",
"version" : "2.7.1"
}
},
{
"identity" : "swift-nio",
"kind" : "remoteSourceControl",
"location" : "https://github.com/apple/swift-nio.git",
"state" : {
"revision" : "c51907a839e63ebf0ba2076bba73dd96436bd1b9",
"version" : "2.81.0"
"revision" : "a18bddb0acf7a40d982b2f128ce73ce4ee31f352",
"version" : "2.86.2"
}
},
{
"identity" : "swift-nio-extras",
"kind" : "remoteSourceControl",
"location" : "https://github.com/apple/swift-nio-extras.git",
"state" : {
"revision" : "00f3f72d2f9942d0e2dc96057ab50a37ced150d4",
"version" : "1.25.0"
"revision" : "a55c3dd3a81d035af8a20ce5718889c0dcab073d",
"version" : "1.29.0"
}
},
{
"identity" : "swift-nio-http2",
"kind" : "remoteSourceControl",
"location" : "https://github.com/apple/swift-nio-http2.git",
"state" : {
"revision" : "a0224f3d20438635dd59c9fcc593520d80d131d0",
"version" : "1.33.0"
"revision" : "5e9e99ec96c53bc2c18ddd10c1e25a3cd97c55e5",
"version" : "1.38.0"
}
},
{
"identity" : "swift-nio-ssl",
"kind" : "remoteSourceControl",
"location" : "https://github.com/apple/swift-nio-ssl.git",
"state" : {
"revision" : "0cc3528ff48129d64ab9cab0b1cd621634edfc6b",
"version" : "2.29.3"
"revision" : "b2b043a8810ab6d51b3ff4df17f057d87ef1ec7c",
"version" : "2.34.1"
}
},
{
"identity" : "swift-nio-transport-services",
"kind" : "remoteSourceControl",
"location" : "https://github.com/apple/swift-nio-transport-services.git",
"state" : {
"revision" : "38ac8221dd20674682148d6451367f89c2652980",
"version" : "1.21.0"
"revision" : "df6c28355051c72c884574a6c858bc54f7311ff9",
"version" : "1.25.2"
}
},
{
"identity" : "swift-numerics",
"kind" : "remoteSourceControl",
"location" : "https://github.com/apple/swift-numerics",
"location" : "https://github.com/apple/swift-numerics.git",
"state" : {
"revision" : "0a5bc04095a675662cf24757cc0640aa2204253b",
"version" : "1.0.2"
"revision" : "0c0290ff6b24942dadb83a929ffaaa1481df04a2",
"version" : "1.1.1"
}
},
{
"identity" : "swift-service-context",
"kind" : "remoteSourceControl",
"location" : "https://github.com/apple/swift-service-context.git",
"state" : {
"revision" : "8946c930cae601452149e45d31d8ddfac973c3c7",
"version" : "1.2.0"
"revision" : "1983448fefc717a2bc2ebde5490fe99873c5b8a6",
"version" : "1.2.1"
}
},
{
"identity" : "swift-service-lifecycle",
"kind" : "remoteSourceControl",
"location" : "https://github.com/swift-server/swift-service-lifecycle.git",
"state" : {
"revision" : "1de37290c0ab3c5a96028e0f02911b672fd42348",
"version" : "2.9.1"
}
},
{
"identity" : "swift-system",
"kind" : "remoteSourceControl",
"location" : "https://github.com/apple/swift-system.git",
"state" : {
"revision" : "a34201439c74b53f0fd71ef11741af7e7caf01e1",
"version" : "1.4.2"
"revision" : "395a77f0aa927f0ff73941d7ac35f2b46d47c9db",
"version" : "1.6.3"
}
},
{
"identity" : "vapor",
"kind" : "remoteSourceControl",
"location" : "https://github.com/vapor/vapor.git",
"state" : {
"revision" : "a425e32f9b9d19c0ecab952cb4484c1c15e2536f",
"version" : "4.113.2"
"revision" : "175735995159e65cd52579ccf1d3c725623a09ee",
"version" : "4.117.2"
}
},
{
"identity" : "websocket-kit",
"kind" : "remoteSourceControl",
"location" : "https://github.com/vapor/websocket-kit.git",
"state" : {
"revision" : "4232d34efa49f633ba61afde365d3896fc7f8740",
"version" : "2.15.0"
"revision" : "8666c92dbbb3c8eefc8008c9c8dcf50bfd302167",
"version" : "2.16.1"
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick | 🔵 Trivial

Lockfile updates align with the new manifest—ensure they’re generated with your CI toolchain!

These revised pins and added packages (Vapor/NIO/crypto/Parse‑Swift ecosystem, plus service‑context/lifecycle, etc.) look consistent with the new Package.swift constraints and the Vapor 4.117.2 update. Make sure this Package.resolved was regenerated by SwiftPM using the same Swift/Xcode toolchain your CI (e.g. Xcode 16.4) runs, so different machines don’t constantly rewrite the lockfile. Plus Ultra!

🤖 Prompt for AI Agents
In Package.resolved around lines 8 to 262, the lockfile was updated to new
package revisions (Vapor, NIO, crypto, Parse‑Swift, service‑context/lifecycle,
etc.) and the reviewer asks that it must be regenerated by SwiftPM with the
exact CI Swift/Xcode toolchain; regenerate Package.resolved locally using the
same Swift/Xcode version your CI uses (e.g. Xcode 16.4 / swiftpm from that
toolchain), run swift package resolve (or xcodebuild resolve) to produce a fresh
lockfile, verify no workspace-specific overrides or local package paths remain,
run CI to ensure the file is stable across machines, and commit the regenerated
Package.resolved so CI does not continually rewrite it.

Comment on lines 22 to 96
.package(
url: "https://github.com/vapor/vapor.git",
.upToNextMajor(from: "4.113.2")
exact: Version(4, 117, 2)

),
.package(
url: "https://github.com/netreconlab/Parse-Swift.git",
.upToNextMajor(from: "5.12.0")
)
.upToNextMajor(from: "5.12.3")
),
.package(
url: "https://github.com/apple/swift-collections.git",
exact: Version(1, 1, 6)

),
.package(
url: "https://github.com/apple/swift-nio.git",
exact: Version(2, 86, 2)

),
.package(
url: "https://github.com/apple/swift-nio-http2.git",
exact: Version(1, 38, 0)

),
.package(
url: "https://github.com/apple/swift-log.git",
exact: Version(1, 6, 4)

),
.package(
url: "https://github.com/apple/swift-nio-ssl.git",
exact: Version(2, 34, 1)

),
.package(
url: "https://github.com/apple/swift-crypto.git",
exact: Version(3, 15, 1)

),
.package(
url: "https://github.com/swift-server/async-http-client.git",
exact: Version(1, 29, 1)

),
.package(
url: "https://github.com/apple/swift-nio-extras.git",
exact: Version(1, 29, 0)

),
.package(
url: "https://github.com/apple/swift-asn1.git",
exact: Version(1, 4, 0)

),
.package(
url: "https://github.com/apple/swift-async-algorithms.git",
exact: Version(1, 0, 4)

),
.package(
url: "https://github.com/apple/swift-certificates.git",
exact: Version(1, 15, 1)

),
.package(
url: "https://github.com/apple/swift-http-structured-headers.git",
exact: Version(1, 4, 0)

),
.package(
url: "https://github.com/apple/swift-nio-transport-services.git",
exact: Version(1, 25, 2)

)
],
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick | 🔵 Trivial

Manifest stands tall with precise pins—confirm this strict version strategy is your intent, hero!

You’ve upgraded Vapor to exact: Version(4, 117, 2), nudged Parse‑Swift to 5.12.3, and added exact pins for the wider Vapor/NIO/log/crypto stack. This gives you very reproducible builds, which is great for a HIPAA‑sensitive service, but it also means you’ll miss automatic patch‑level fixes unless you deliberately bump these versions again.

If this strict pinning is intentional for compliance/control, the setup looks coherent with Package.resolved. Otherwise, you might consider relaxing some of these to .upToNextMinor/.upToNextMajor so future security and bugfix releases flow in more naturally. Also, double‑check that all these exact versions are supported by your Swift 5.7 toolchain and Xcode 16.4 target. Plus Ultra!

🤖 Prompt for AI Agents
In Package.swift around lines 22–96 you’ve pinned many dependencies with exact
versions (Vapor, SwiftNIO, crypto, etc.), which enforces reproducible builds but
prevents automatic patch updates; confirm this strict pinning is intentional for
compliance, otherwise relax selected package requirements (e.g., change exact
pins to .upToNextMinor or .upToNextMajor for non-critical libs like
swift-collections, swift-log, async-http-client) to allow safe patch/minor
upgrades, ensure all chosen ranges are compatible with your Swift 5.7 / Xcode
16.4 toolchain, regenerate/commit Package.resolved, and add a short comment or
CONTRIBUTING note documenting the chosen versioning strategy and who is
responsible for manual bumps.

@cbaker6 cbaker6 changed the title fix: Cap all dependencies to work on Swift 5.10 image fix: Pin all dependencies to work on Swift 5.10 image Dec 10, 2025
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 87f8504 and 52288dc.

📒 Files selected for processing (1)
  • Package.swift (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: spm-test
  • GitHub Check: linux
🔇 Additional comments (2)
Package.swift (2)

1-1: A hero's foundation, set to Swift 5.10—this is the version of justice you seek!

The tools version bump to 5.10 aligns perfectly with your stated objective to support the Swift 5.10 Linux image. Well done, young hero!


22-26: The Vapor framework stands locked at version 4.117.2—your intent is clear as day!

Based on your PR objectives to lock down dependencies for Swift 5.10 compatibility, this exact pinning strategy is absolutely justified. The previous review's concerns are now answered by your clear rationale. Plus Ultra!

Comment on lines 27 to +30
.package(
url: "https://github.com/netreconlab/Parse-Swift.git",
.upToNextMajor(from: "5.12.0")
)
.upToNextMajor(from: "5.12.3")
),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

cat -n Package.swift

Repository: netreconlab/parse-server-swift

Length of output: 4071


Parse-Swift uses .upToNextMajor while all other 14 dependencies are pinned to exact versions.

This creates an inconsistency in your version lockdown strategy. Parse-Swift allows any version from 5.12.3 to 5.99.99, while Vapor, swift-nio, swift-collections, and every other dependency use exact pins. If a future 5.13.x or 5.14.x release requires Swift 6.x (without a major version bump), your Swift 5.10 builds could break.

For consistency, pin Parse-Swift to the exact version:

         .package(
             url: "https://github.com/netreconlab/Parse-Swift.git",
-            .upToNextMajor(from: "5.12.3")
+            exact: Version(5, 12, 3)
         ),
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
.package(
url: "https://github.com/netreconlab/Parse-Swift.git",
.upToNextMajor(from: "5.12.0")
)
.upToNextMajor(from: "5.12.3")
),
.package(
url: "https://github.com/netreconlab/Parse-Swift.git",
exact: Version(5, 12, 3)
),
🤖 Prompt for AI Agents
In Package.swift around lines 27 to 30, the Parse-Swift dependency is declared
with .upToNextMajor(from: "5.12.3") which is inconsistent with the project's
exact-version locking; change that to pin Parse-Swift to the exact version
5.12.3 (use the SwiftPM exact pin form) so it matches the other 14 dependencies
and prevents inadvertent upgrades.

Comment on lines +31 to +95
.package(
url: "https://github.com/apple/swift-collections.git",
exact: Version(1, 1, 6)

),
.package(
url: "https://github.com/apple/swift-nio.git",
exact: Version(2, 86, 2)

),
.package(
url: "https://github.com/apple/swift-nio-http2.git",
exact: Version(1, 38, 0)

),
.package(
url: "https://github.com/apple/swift-log.git",
exact: Version(1, 6, 4)

),
.package(
url: "https://github.com/apple/swift-nio-ssl.git",
exact: Version(2, 34, 1)

),
.package(
url: "https://github.com/apple/swift-crypto.git",
exact: Version(3, 15, 1)

),
.package(
url: "https://github.com/swift-server/async-http-client.git",
exact: Version(1, 29, 1)

),
.package(
url: "https://github.com/apple/swift-nio-extras.git",
exact: Version(1, 29, 0)

),
.package(
url: "https://github.com/apple/swift-asn1.git",
exact: Version(1, 4, 0)

),
.package(
url: "https://github.com/apple/swift-async-algorithms.git",
exact: Version(1, 0, 4)

),
.package(
url: "https://github.com/apple/swift-certificates.git",
exact: Version(1, 15, 1)

),
.package(
url: "https://github.com/apple/swift-http-structured-headers.git",
exact: Version(1, 4, 0)

),
.package(
url: "https://github.com/apple/swift-nio-transport-services.git",
exact: Version(1, 25, 2)

)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick | 🔵 Trivial

🧩 Analysis chain

🏁 Script executed:

cat Package.swift

Repository: netreconlab/parse-server-swift

Length of output: 3217


🏁 Script executed:

#!/bin/bash
# Check Swift version requirement from main Package.swift
echo "=== Main Package.swift swift-tools-version ==="
grep -m1 "swift-tools-version" Package.swift || echo "Not found"

Repository: netreconlab/parse-server-swift

Length of output: 148


🏁 Script executed:

#!/bin/bash
# Check Swift version requirements for the pinned dependencies
# We'll use curl to fetch Package.swift from GitHub tags

check_swift_version() {
  local repo=$1
  local version=$2
  local name=$3
  
  echo "=== Checking $name $version ==="
  curl -s "https://raw.githubusercontent.com/$repo/$version/Package.swift" 2>/dev/null | grep -E "swift-tools-version|\.macOS|\.iOS" | head -5 || echo "Could not fetch or parse"
}

# Check key dependencies
check_swift_version "apple/swift-nio" "2.86.2" "swift-nio"
check_swift_version "apple/swift-collections" "1.1.6" "swift-collections"
check_swift_version "apple/swift-crypto" "3.15.1" "swift-crypto"
check_swift_version "swift-server/async-http-client" "1.29.1" "async-http-client"
check_swift_version "vapor/vapor" "4.117.2" "vapor"

Repository: netreconlab/parse-server-swift

Length of output: 633


Explicit pinning of transitive dependencies ensures reproducible builds.

Making previously transitive dependencies explicit with exact version pins is a sound dependency management strategy that prevents unexpected version resolution variations. The pinned versions—swift-collections 1.1.6, swift-nio 2.86.2, swift-nio-http2 1.38.0, swift-log 1.6.4, swift-nio-ssl 2.34.1, swift-crypto 3.15.1, async-http-client 1.29.1, swift-nio-extras 1.29.0, swift-asn1 1.4.0, swift-async-algorithms 1.0.4, swift-certificates 1.15.1, swift-http-structured-headers 1.4.0, and swift-nio-transport-services 1.25.2—are all compatible with Swift 5.10.

However, exact pinning comes with a trade-off: it sacrifices flexibility for reproducibility. Consider whether you could use version ranges (e.g., .upToNextMajor) for some of these dependencies to allow security patches and bug fixes without requiring manual updates, similar to your approach with Parse-Swift. This would balance reproducibility with maintainability.

🤖 Prompt for AI Agents
Package.swift lines 31-95: The review notes that currently many transitive
dependencies are pinned with exact versions which ensures reproducible builds
but reduces flexibility; update Package.swift to replace exact Version(...) pins
with appropriate semantic ranges (for example .upToNextMajor(from: "1.29.1") or
.upToNextMinor(...) where safe) for dependencies that do not require strict
pinning, while keeping exact pins only for packages that must remain immutable;
verify compatibility with Swift 5.10 and run swift package resolve/test to
confirm no resolution conflicts, then commit the updated dependency
specifications.

@cbaker6 cbaker6 merged commit d43b06d into main Dec 10, 2025
5 of 6 checks passed
@cbaker6 cbaker6 deleted the updateDeps branch December 10, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants