Skip to content

ci(tests): run tests via reusable python-ci workflow#89

Merged
CybotTM merged 1 commit into
mainfrom
chore/test-via-reusable-python-ci
Jun 7, 2026
Merged

ci(tests): run tests via reusable python-ci workflow#89
CybotTM merged 1 commit into
mainfrom
chore/test-via-reusable-python-ci

Conversation

@CybotTM

@CybotTM CybotTM commented Jun 7, 2026

Copy link
Copy Markdown
Member

What

Replaces the inline Test Suite job with the org-standard netresearch/.github/.github/workflows/python-ci.yml@main reusable (added in netresearch/.github#174). It runs the unit + integration pytest suites with coverage and uploads to Codecov.

lint, security, build, docs, and integration-e2e are unchanged. The reusable caller keeps the job name test, so the needs: [lint, test] / needs: [test] dependencies stay valid.

Why

Renovate was bumping codecov/codecov-action in this repo per release (#88). The action now lives once in python-ci.yml and is pinned/bumped centrally — the same model PHP repos use via php-ci.yml. There is no longer an inline codecov-action reference here.

Closes #88.

Behavior notes

  • Test execution still runs across ubuntu-latest, macos-latest, windows-latest on Python 3.14.
  • Coverage now uploads once (ubuntu / 3.14) instead of from all three OS cells — the previous setup uploaded three reports with different name= values.
  • Install still uses pip install -r requirements-dev.txt (matching the previous job; not switched to uv).

Residual

The lint, security, build, docs, integration-e2e jobs still pin actions/checkout / actions/setup-python, which Renovate will still bump occasionally. This PR stops the codecov churn specifically.

Validation

yamllint (org config) and actionlint clean.

Replace the inline Test Suite job with the org-standard
netresearch/.github python-ci.yml@main reusable (unit + integration
pytest with coverage, Codecov upload). Removes the per-repo
codecov-action reference that Renovate kept bumping (#88); the action is
now pinned once in netresearch/.github. Coverage uploads once
(ubuntu/3.14) instead of from every matrix cell.

The lint, security, build, docs and integration-e2e jobs are unchanged;
build/integration-e2e still depend on the 'test' job by name.

Signed-off-by: Sebastian Mendel <info@sebastianmendel.de>
Copilot AI review requested due to automatic review settings June 7, 2026 08:34
@gemini-code-assist

Copy link
Copy Markdown

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@github-actions

github-actions Bot commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Dependency Review

The following issues were found:
  • ✅ 0 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ⚠️ 1 package(s) with unknown licenses.
See the Details below.

License Issues

.github/workflows/ci.yml

PackageVersionLicenseIssue Type
netresearch/.github/.github/workflows/python-ci.ymlmainNullUnknown License

OpenSSF Scorecard

PackageVersionScoreDetails
actions/netresearch/.github/.github/workflows/python-ci.yml main UnknownUnknown

Scanned Files

  • .github/workflows/ci.yml

@sonarqubecloud

sonarqubecloud Bot commented Jun 7, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarQube Cloud

@codecov

codecov Bot commented Jun 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.87%. Comparing base (b332f09) to head (9e27645).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
- Coverage   69.47%   68.87%   -0.60%     
==========================================
  Files          22       22              
  Lines        3345     3345              
==========================================
- Hits         2324     2304      -20     
- Misses       1021     1041      +20     
Flag Coverage Δ
unittests 68.87% <ø> (-0.60%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the repository’s CI pipeline by replacing the inline test job implementation with the org-standard reusable workflow netresearch/.github/.github/workflows/python-ci.yml@main, keeping the test job identifier intact so existing needs: [test] dependencies continue to work.

Changes:

  • Replaced the inline matrix-based pytest + coverage + Codecov upload job with the reusable python-ci.yml workflow.
  • Configured the reusable workflow to run unit + integration tests across ubuntu-latest, macos-latest, windows-latest on Python 3.14.
  • Adjusted coverage upload behavior to upload to Codecov only once (ubuntu / 3.14) instead of from every matrix cell.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@CybotTM CybotTM merged commit 3738bc9 into main Jun 7, 2026
20 of 22 checks passed
@CybotTM CybotTM deleted the chore/test-via-reusable-python-ci branch June 7, 2026 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants