ci(pr-quality): add caller for the org-wide PR Quality Gates reusable#14
Merged
Conversation
This repo was missing the standard Netresearch PR-quality + auto-approve workflow that other org repos use (netresearch/ofelia, phpbu-docker as of c1d02e0, netresearch/ldap-selfservice-password-changer, the t3x-* TYPO3 extensions, etc.). Adding the canonical caller. The reusable (netresearch/.github/.github/workflows/pr-quality.yml@main) provides: - PR size labeling (warns over 500 lines changed, alerts over 1000) - Auto-approve for maintainer PRs whose author_association is one of OWNER / MEMBER / COLLABORATOR. Useful even without strict branch protection: the same Copilot ruleset that runs the Copilot review bot also requests "1 approval" on some PRs, and this auto-approve satisfies that gate for routine maintainer work. Copilot's own review runs separately via the ruleset, NOT via this workflow. Caller config matches the pattern used in netresearch/ofelia + netresearch/phpbu-docker verbatim (modulo SPDX header) — no caller-side knobs needed. Signed-off-by: Sebastian Mendel <info@sebastianmendel.de>
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Automated approval for maintainer PR
All automated quality gates passed. See SECURITY_CONTROLS.md for compensating controls.
There was a problem hiding this comment.
Pull request overview
Adds the repository-standard GitHub Actions workflow that calls Netresearch’s org-wide “PR Quality Gates” reusable workflow, bringing this repo in line with the container/library repos’ CI policy.
Changes:
- Introduces a new
PR Quality Gatesworkflow triggered on PR events tomain. - Delegates PR size labeling and maintainer auto-approval to
netresearch/.github/.github/workflows/pr-quality.yml@main. - Scopes the
GITHUB_TOKENpermissions to only what the caller job needs (contents: read,pull-requests: write) with workflow-level permissions disabled by default.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the same org-policy gap that was just fixed in netresearch/phpbu-docker#124: this repo was missing the canonical
pr-quality.ymlcaller that every other Netresearch container/library repo uses (netresearch/ofelia, netresearch/phpbu-docker, netresearch/ldap-selfservice-password-changer, the t3x-* TYPO3 extensions).What the reusable does
author_association ∈ {OWNER, MEMBER, COLLABORATOR}gets a programmatic approval. Useful both for branch-protection "1 approval" gates and the Copilot ruleset's "1 approval" requirement. Copilot's review bot still runs separately via the org-level Copilot ruleset (not via this workflow), so it doesn't bypass that gate.Caller config
Matches the netresearch/ofelia and netresearch/phpbu-docker callers verbatim (modulo SPDX header). No caller-side knobs needed.
Test plan
actionlintcleanNote re SonarCloud
Adds one
@mainreusable ref → may surface a newgithubactions:S7637LOW hotspot. The project's Quality Profile rule deactivation (done during PR #11) should already cover this. If not, mark SAFE per the org pattern.