LiteDataMap.hdf now gets copied over when user calibration folder gets created#681
Open
dlcaballero16 wants to merge 6 commits into
Open
LiteDataMap.hdf now gets copied over when user calibration folder gets created#681dlcaballero16 wants to merge 6 commits into
dlcaballero16 wants to merge 6 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #681 +/- ##
=======================================
Coverage 96.47% 96.47%
=======================================
Files 79 79
Lines 7258 7258
=======================================
Hits 7002 7002
Misses 256 256
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of work
When a user has no write permissions and the calibration folder is created under ~/snapred, LiteDataMap.hdf is now included when the folder is created.
Explanation of work
copyCalibrationRootSkeletonin LocalDataService.py was updated to copy over LiteGroupMap.hdf too.To test
Dev testing
On analysis, check and make sure that ~/.snapred/Calibration does not already exist. Now, attempt to run DiffCal on run 59039 and click yes on the prompt to create a new Calibration folder. Now inspect the newly created ~/.snapred/Calibration folder and see that Powder now contains LiteGroupMap.hdf.
CIS testing
Essentially do the steps in Dev testing, but make sure you update your config so that you don't have write permissions, otherwise the ~/.snapred/Calibration folder won't get generated.
Link to EWM item
EWM#15722
Verification
Acceptance Criteria
This list is for ease of reference, and does not replace reading the EWM story as part of the review. Verify this list matches the EWM story before reviewing.