feat: add support for probe config and ui svc labels #487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Also happy to add some defaults for any of these - we've struggled with missing probes on enforcer/controller and added our own that just probe tcp ports, but I'm not sure if they are the best here. |
Contributor
Author
|
@holyspectral any feedback on this one? |
|
Would also love to see this merged in. @holyspectral any issues with pushing this through? |
|
Hey, one more supporter here for the merge of this PR, much appreciated. We've seen in our environment some random delay in the OIDC endpoint availability, that caused the controller to be shutdown (killed) after many retries and never restarted because there is no liveness probe :-( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #252 by providing a way to configure probes across the controllers/enforcers.
Also adds support for labels on the manager service which is useful for Istio ambient waypoint usage (see here).