test(encode): use existing strRepeat from string utilities instead of redefining it#524
Merged
nev21 merged 2 commits intonev21/encodefrom Feb 26, 2026
Merged
test(encode): use existing strRepeat from string utilities instead of redefining it#524nev21 merged 2 commits intonev21/encodefrom
nev21 merged 2 commits intonev21/encodefrom
Conversation
Co-authored-by: nev21 <82737406+nev21@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Work in progress on feedback for encoding utilities
test(encode): use existing strRepeat from string utilities instead of redefining it
Feb 26, 2026
nev21
approved these changes
Feb 26, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR eliminates code duplication in the test suite by removing a locally-defined helper function that already exists as a well-tested utility in the library.
Changes:
- Removed the local
strRepeathelper function fromencode.test.ts(9 lines) - Added import statement to use the existing
strRepeatutility fromsrc/string/repeat
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## nev21/encode #524 +/- ##
=============================================
Coverage 98.78% 98.78%
=============================================
Files 111 111
Lines 3384 3384
Branches 738 738
=============================================
Hits 3343 3343
Misses 41 41 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The encode test file had a locally defined
strRepeathelper that duplicated the already-exportedstrRepeatfromsrc/string/repeat.Changes
strRepeatfunction definition fromencode.test.tsstrRepeatfrom../../../../src/string/repeat💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.