Hybrid core tracing rebased

[hmstepanek]

Overview

Merge rebased develop-hybrid-core-tracing branch into main.

[github-actions]

✅MegaLinter analysis: Success

Descriptor	Linter	Files	Fixed	Errors	Warnings	Elapsed time
✅ ACTION	actionlint	7		0	0	1.18s
✅ MARKDOWN	markdownlint	7	0	0	0	1.28s
✅ PYTHON	ruff	1037	0	0	0	1.22s
✅ PYTHON	ruff-format	1037	0	0	0	0.36s
✅ YAML	prettier	15	0	0	0	1.54s
✅ YAML	v8r	15		0	0	6.24s
✅ YAML	yamllint	15		0	0	0.66s

See detailed reports in MegaLinter artifacts

[codecov-commenter]

Codecov Report

❌ Patch coverage is 82.70440% with 220 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.27%. Comparing base (0474217) to head (02bb794).

Files with missing lines	Patch %	Lines
newrelic/api/opentelemetry.py	83.17%	39 Missing and 31 partials ⚠️
newrelic/config.py	66.41%	44 Missing ⚠️
newrelic/hooks/hybridagent_opentelemetry.py	73.10%	24 Missing and 15 partials ⚠️
newrelic/core/config.py	88.13%	10 Missing and 4 partials ⚠️
newrelic/api/time_trace.py	64.28%	5 Missing and 5 partials ⚠️
newrelic/core/agent.py	64.00%	6 Missing and 3 partials ⚠️
newrelic/core/node_mixin.py	92.96%	3 Missing and 6 partials ⚠️
newrelic/core/application.py	72.41%	3 Missing and 5 partials ⚠️
newrelic/api/transaction.py	95.18%	2 Missing and 2 partials ⚠️
newrelic/core/database_utils.py	75.00%	2 Missing and 2 partials ⚠️
... and 4 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1646      +/-   ##
==========================================
- Coverage   81.69%   80.27%   -1.42%     
==========================================
  Files         210      215       +5     
  Lines       24655    25827    +1172     
  Branches     3884     4108     +224     
==========================================
+ Hits        20141    20733     +592     
- Misses       3198     3642     +444     
- Partials     1316     1452     +136     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[TimPansino]

Do these need to be done at import time? I would prefer if they were in an initialize function or something.

[lrafeei]

What do you think of putting this logic in the agent initialization function (specifically the tracer_provider function)?

[TimPansino]

Could we by chance annotate this class with a comment that defines what each of these field abbreviations are? All this is a bit incomprehensible if you don't have these abbreviations memorized.

[TimPansino]

Lot of commented out stuff in this file that should be trimmed out or enabled.

[lrafeei]

I will leave a few commented out lines. starlette.concurrency needs to remain enabled, but it seems like an odd one out. I am leaving it in there along with the note for future reference.

Similarly, I will leave in the commented out spots for boto/botocore due to the notes accompanying them (and because these will need to be included in the future)

[TimPansino]

Is there a reason this file exists separately and isn't part of the newrelic/api/opentelemetry.py file? If it needs to be separate, can we get rid of the otel abbreviation and make this file opentelemetry_tracers.py maybe?

[lrafeei]

The only reason it is a separate file is just for readability. This file is going to get much larger in the near future (and so will newrelic/api/opentelemetry.py). But sure, I can change the file name.

[TimPansino]

Can we avoid the abbreviation and call this opentelemetry_tracer_provider instead?