Skip to content

feat (existence-check-remote-operation): retry policy#1971

Draft
alperozturk96 wants to merge 2 commits intomasterfrom
make-existence-check-remote-operation-retrayable
Draft

feat (existence-check-remote-operation): retry policy#1971
alperozturk96 wants to merge 2 commits intomasterfrom
make-existence-check-remote-operation-retrayable

Conversation

@alperozturk96
Copy link
Contributor

@alperozturk96 alperozturk96 commented Mar 16, 2026

Client: nextcloud/android#16694

Changes

Adds retry policy
Converts to Kotlin
Introduces HTTP codes object for general use including this one
Adds isTransientFailure extension for RemoteOperation

@github-actions
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3434
Correctness3434
Dodgy code2525
Internationalization66
Malicious code vulnerability4948
Multithreaded correctness1111
Performance88
Total167166

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@github-actions
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3434
Correctness3434
Dodgy code2525
Internationalization66
Malicious code vulnerability4948
Multithreaded correctness1111
Performance88
Total167166

@alperozturk96
Copy link
Contributor Author

/backport to stable-2.23.0

Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alperozturk96
Copy link
Contributor Author

unrelated?

Screenshot 2026-03-17 at 13 57 09

* @param successIfAbsent When `true` a 404 is treated as success (absence check).
* @param retryPolicy Controls how many times and how long to retry.
*/
class ExistenceCheckRemoteOperation
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to achieve on higher level in clients instead of individual child remote operation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants