Open
Conversation
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
| - Use modern Java for Java classes. Optionals, virtual threads, records, streams if necessary. | ||
|
|
||
| - Avoid hardcoded strings, colors, dimensions. Use resources. | ||
| - For linting / formatting, use ktlint or detekt for Kotlin, and Android Lint for Java. |
Member
There was a problem hiding this comment.
Works I suppose. You can also just list the gradle tasks to be executed and new issues found to be fixed before committing the changes.
Member
There was a problem hiding this comment.
Yeah, being here more specific might help (at least an human could benefit from it):
Suggested change
| - For linting / formatting, use ktlint or detekt for Kotlin, and Android Lint for Java. | |
| - Run lint, spotbugsGplayDebug, detekt, spotlessKotlinCheck and fix findings inside the files that have been changed. |
AndyScherzinger
approved these changes
Mar 17, 2026
|
blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16697.apk |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.