Skip to content

Conversation

@claucambra
Copy link
Contributor

Warning

Depends on #27

@claucambra claucambra self-assigned this Dec 5, 2024
@claucambra claucambra force-pushed the feature/trash branch 3 times, most recently from 543f41f to 8c1b6bf Compare December 11, 2024 08:39
@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 84.25116% with 306 lines in your changes missing coverage. Please review.

Project coverage is 77.72%. Comparing base (64d5844) to head (bbc2b4f).
Report is 181 commits behind head on main.

Files with missing lines Patch % Lines
...es/NextcloudFileProviderKit/Item/Item+Modify.swift 55.66% 188 Missing ⚠️
...tcloudFileProviderKit/Enumeration/Enumerator.swift 64.86% 26 Missing ⚠️
...erKit/Interface/NextcloudKit+RemoteInterface.swift 0.00% 22 Missing ⚠️
Sources/NextcloudFileProviderKit/Item/Item.swift 40.54% 22 Missing ⚠️
...s/NextcloudFileProviderKitTests/AccountTests.swift 0.00% 13 Missing ⚠️
Tests/Interface/MockRemoteInterface.swift 91.89% 12 Missing ⚠️
...es/NextcloudFileProviderKit/Item/Item+Delete.swift 76.47% 8 Missing ⚠️
...s/NextcloudFileProviderKit/Utilities/Account.swift 20.00% 8 Missing ⚠️
...xtcloudFileProviderKit/Metadata/ItemMetadata.swift 57.14% 6 Missing ⚠️
...extcloudFileProviderKitTests/ItemModifyTests.swift 99.86% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
+ Coverage   76.57%   77.72%   +1.14%     
==========================================
  Files          38       42       +4     
  Lines        8236     9850    +1614     
==========================================
+ Hits         6307     7656    +1349     
- Misses       1929     2194     +265     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@claucambra claucambra force-pushed the feature/trash branch 4 times, most recently from 7c76493 to cea1baa Compare December 16, 2024 04:54
@claucambra claucambra added this to the 2.0.0 milestone Dec 18, 2024
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
…e manager

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>

f acc test

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
…metadata

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Per the behaviour on the server; fileName always pertains to the actual
real filename in the server filesystem, whereas trashbinFileName is what
is displayed to the user

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
For trashed items the server only provides a fileId as the ocId, not the
actual ocId. We can work around this by setting the original ocId on the
NKTrash converted to ItemMetadata metadata

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
This was changed so that trashbinFileName is the display name, leaving
fileName as always the truthful file name

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
…e reliable

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
…estore first in mock remote interface

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
… remote interface

However on conversion retain the original identifier as the fileId,
matching the behaviour of the current nc server (which returns the
item's ocIds as the fileIds, not the original ocIds)

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
They need to check for the mangled identifiers instead

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
@claucambra claucambra merged commit 9326f6b into main Dec 19, 2024
3 checks passed
@claucambra claucambra added the enhancement New feature or request label Jan 9, 2025
@Rello Rello deleted the feature/trash branch August 15, 2025 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants