fix: Fix "Failed to fetch collection list" when trying to open albums

[jancborchardt]

Before	After

Possibly related:

• [Bug] Failed to fetch albums list when go to Albums - also can't add photos to albums #1398
• [Bug]: NC 25 Failed to fetch albums lists  #1197

---

AI-assisted: GitHub Copilot (Claude Sonnet 4.6)

Prompt

I’m getting "Failed to fetch collection list" when trying to open albums. These are the errors from the browser console:

“https://nextcloud.local/apps-extra/profiler/css/profiler-toolbar.css” was blocked due to MIME type (“text/html”) mismatch (X-Content-Type-Options: nosniff). Cityscapes        
The resource from “https://nextcloud.local/apps/comments/css/comments-tab.css” was blocked due to MIME type (“text/html”) mismatch (X-Content-Type-Options: nosniff). Cityscapes
The resource from “https://nextcloud.local/apps/files_versions/css/sidebar-tab.css” was blocked due to MIME type (“text/html”) mismatch (X-Content-Type-Options: nosniff).      
Cityscapes                                                                                                                                                                      
Uncaught TypeError: can't access property "Tab", OCA.Files.Sidebar is undefined                                                                                                 
    <anonymous> sidebar.ts:21                                                                                                                                                   
sidebar.ts:21:19                                                                                                                                                                
[ERROR] photos: Error fetching collection files                                                                                                                                 
Object { app: "photos", uid: "admin", level: 0, error: Error }                                                                                                                  
index.mjs:54:17                                                                                                                                                                 
[ERROR] photos: [PublicCollectionContent] Error fetching collection files                                                                                                       
Object { app: "photos", uid: "admin", level: 0, error: Error }                                                                                                                  
index.mjs:54:17                                                                                                                                                                 
XHR                                                                                                                                                                             
PROPFIND                                                                                                                                                                        
https://nextcloud.local/remote.php/dav/photos/admin/albums/Recent/                                                                                                              
[HTTP/2 500  161ms]                                                                                                                                                             
                                                                                                                                                                                
[ERROR] photos: Error fetching collection files                                                                                                                                 
Object { app: "photos", uid: "admin", level: 0, error: Error }                                                                                                                  
index.mjs:54:17                                                                                                                                                                 
[ERROR] photos: [PublicCollectionContent] Error fetching collection files                                                                                                       
Object { app: "photos", uid: "admin", level: 0, error: Error }                                                                                                                  
index.mjs:54:17                                                                                                                                                                 
XHR                                                                                                                                                                             
PROPFIND                                                                                                                                                                        
https://nextcloud.local/remote.php/dav/photos/admin/albums/Cityscapes/                                                                                                          
[HTTP/2 500  131ms]                                                                                                                                                             
                                                                                                                                                                                
[ERROR] photos: Error fetching collection files                                                                                                                                 
Object { app: "photos", uid: "admin", level: 0, error: Error }                                                                                                                  
index.mjs:54:17                                                                                                                                                                 
[ERROR] photos: [PublicCollectionContent] Error fetching collection files                                                                                                       
Object { app: "photos", uid: "admin", level: 0, error: Error }                                                                                                                  
index.mjs:54:17 

Output

The fix is clear: getDavPermissions() now requires a second FileInfo $parent argument, but PropFindPlugin.php only passes one. The $fileInfo variable is already available in the
  closure's outer scope.

The PROPFIND now returns HTTP 200 with all photos and their permissions (e.g. GDNVW). The fix works.

  Root cause: OCP\Files\DavUtil::getDavPermissions() was updated to require a second FileInfo $parent argument (used to compute rename permissions), but PropFindPlugin.php was still
  calling it with only one argument.

  Fix: Pass $fileInfo->getParent() as the second argument, reusing the $fileInfo variable already captured in the closure's outer scope.

[artonge]

Closing in favour of #3475

Thanks anyway :)