Skip to content

feat (2fa): Add IStatelessProvider interface #57216

Open
Roszakos wants to merge 6 commits intonextcloud:masterfrom
Roszakos:2fa-stateless-provider-interface
Open

feat (2fa): Add IStatelessProvider interface #57216
Roszakos wants to merge 6 commits intonextcloud:masterfrom
Roszakos:2fa-stateless-provider-interface

Conversation

@Roszakos
Copy link

@Roszakos Roszakos commented Dec 20, 2025

Summary

Adds an IStatelessProvider interface. Per-user 2FA activation state for providers implementing this interface will not be stored in the database, thus isTwoFactorAuthEnabledForUser method will be called on every login attempt.

Checklist

Signed-off-by: Michał Roszak <m.roszakos@gmail.com>
@Roszakos Roszakos requested review from ArtificialOwl, come-nc, icewind1991 and provokateurin and removed request for a team December 20, 2025 13:22
Signed-off-by: Michał Roszak <m.roszakos@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2026

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@come-nc
Copy link
Contributor

come-nc commented Jan 6, 2026

Apart from the license issue, looks good 👍

Signed-off-by: Michał Roszak <m.roszakos@gmail.com>
@Furgas
Copy link

Furgas commented Feb 18, 2026

Is there anything left to do in this pull request? In what version are you plannig to include this change?

@miaulalala
Copy link
Contributor

miaulalala commented Mar 2, 2026

Looks like you need to update your autoloaders:

The autoloaders are not up to date
Please run: bash build/autoloaderchecker.sh
And commit the result

Roszakos added 2 commits March 2, 2026 17:10
Signed-off-by: Michał Roszak <m.roszakos@gmail.com>
Signed-off-by: Michał Roszak <m.roszakos@gmail.com>
@Roszakos
Copy link
Author

Roszakos commented Mar 2, 2026

It's done. Let me know if there is anything else that could prevent this change from getting pulled.

@miaulalala
Copy link
Contributor

It's done. Let me know if there is anything else that could prevent this change from getting pulled.

Thanks for doing that! Let me start the workflows and see where we're at.

@miaulalala miaulalala requested review from CarlSchwan and come-nc March 2, 2026 16:34
@miaulalala
Copy link
Contributor

Looking good! Last commit is missing the signoff, you can add it with

git commit --amend --signoff and then
git push --force-with-lease

@miaulalala miaulalala self-requested a review March 3, 2026 11:15
Signed-off-by: Michał Roszak <m.roszakos@gmail.com>
@Roszakos Roszakos force-pushed the 2fa-stateless-provider-interface branch from 53c5987 to 4fe1332 Compare March 3, 2026 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stateless 2FA providers

7 participants