feat (2fa): Add IStatelessProvider interface #57216
feat (2fa): Add IStatelessProvider interface #57216Roszakos wants to merge 6 commits intonextcloud:masterfrom
Conversation
Signed-off-by: Michał Roszak <m.roszakos@gmail.com>
Signed-off-by: Michał Roszak <m.roszakos@gmail.com>
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
|
Apart from the license issue, looks good 👍 |
Signed-off-by: Michał Roszak <m.roszakos@gmail.com>
|
Is there anything left to do in this pull request? In what version are you plannig to include this change? |
|
Looks like you need to update your autoloaders: |
Signed-off-by: Michał Roszak <m.roszakos@gmail.com>
Signed-off-by: Michał Roszak <m.roszakos@gmail.com>
|
It's done. Let me know if there is anything else that could prevent this change from getting pulled. |
Thanks for doing that! Let me start the workflows and see where we're at. |
|
Looking good! Last commit is missing the signoff, you can add it with
|
Signed-off-by: Michał Roszak <m.roszakos@gmail.com>
53c5987 to
4fe1332
Compare
Summary
Adds an
IStatelessProviderinterface. Per-user 2FA activation state for providers implementing this interface will not be stored in the database, thusisTwoFactorAuthEnabledForUsermethod will be called on every login attempt.Checklist
3. to review, feature component)stable32)