handle case where we can't get the filesize after open in dav get#58550
handle case where we can't get the filesize after open in dav get#58550
Conversation
icewind1991
requested review from
Altahrim,
ArtificialOwl,
artonge and
come-nc
and removed request for
a team
icewind1991
force-pushed
the
dav-open-size-not-found
branch
from
04eaca0 to
9d7d562
Compare
| if ($this->getSize() !== $fsSize) { | ||
| $logger = Server::get(LoggerInterface::class); | ||
| if ($fsSize === false) { | ||
| $logger->warning('file not found on storage after successfully opening it'); |
There was a problem hiding this comment.
Does it make sense (for proper client error code) to throw a StorageNotAvailableException here?
There was a problem hiding this comment.
Given that the file opened successfully, I'm not sure if we should return an error or just try to read the handle we got an hope that that gives the correct content.
We don't really have enough info to determine that.
There was a problem hiding this comment.
Changed my mind on this, probably better to err on throwing an error
icewind1991
force-pushed
the
dav-open-size-not-found
branch
from
9d7d562 to
8fa18ac
Compare
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
I let this be tested, lets see if it fixes dCache
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
was tested successfully 👍
Signed-off-by: Robin Appelman <robin@icewind.nl>
susnux
force-pushed
the
dav-open-size-not-found
branch
from
8fa18ac to
26ba3ca
Compare
|
/backport to stable33 |
|
/backport to stable32 |
|
The backport to # Switch to the target branch and update it
git checkout stable32
git pull origin stable32
# Create the new backport branch
git checkout -b backport/58550/stable32
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 26ba3cac
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/58550/stable32Error: Failed to push branch backport/58550/stable32: remote: Invalid username or token. Password authentication is not supported for Git operations. Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
/backport to stable32 |
|
The backport to # Switch to the target branch and update it
git checkout stable32
git pull origin stable32
# Create the new backport branch
git checkout -b backport/58550/stable32
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 26ba3cac
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/58550/stable32Error: Failed to push branch backport/58550/stable32: remote: Invalid username or token. Password authentication is not supported for Git operations. Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
/backport 26ba3ca to stable32 |
|
The backport to # Switch to the target branch and update it
git checkout stable32
git pull origin stable32
# Create the new backport branch
git checkout -b backport/58550/stable32
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 26ba3cac
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/58550/stable32Error: Failed to push branch backport/58550/stable32: remote: Invalid username or token. Password authentication is not supported for Git operations. Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
stable32: #58737 |
3 participants
Requires