Skip to content

fix(SetupChecks): update Serverid info level (fallback in use) message #58578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joshtrichards wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −1
Open

fix(SetupChecks): update Serverid info level (fallback in use) message #58578

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion apps/settings/lib/SetupChecks/ServerIdConfig.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,12 @@ public function run(): SetupResult {

if ($serverid === PHP_INT_MIN) {
return SetupResult::info(
$this->l10n->t('Server identifier isn’t configured. It is recommended if your Nextcloud instance is running on several PHP servers. Add a server ID in your configuration.'),
$this->l10n->t(
'The ``serverid`` parameter is not configured. '
. 'By default, Nextcloud uses a fallback based on the server hostname. '
. 'The fallback suggests a standalone setup, which is generally safe if your configuration will remain on a single server and never be cloned, migrated, or scaled out. '
. 'However, if you are running Nextcloud on multiple servers, sharing ``config.php``, or you plan to expand your setup in the future, you should explicitly set a unique integer ``serverid`` (0–1023) for each server. '
Comment on lines +44 to +47
Copy link
Collaborator

@Altahrim Altahrim Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from mixed indentation, we can assume fallback is safe for standalone setup (even if hostname change).
I also think the share of config.php is confusing. If it's shared it means several servers are parts of the same instance and you fall in multiple servers, no?

Suggested change
'The ``serverid`` parameter is not configured. '
. 'By default, Nextcloud uses a fallback based on the server hostname. '
. 'The fallback suggests a standalone setup, which is generally safe if your configuration will remain on a single server and never be cloned, migrated, or scaled out. '
. 'However, if you are running Nextcloud on multiple servers, sharing ``config.php``, or you plan to expand your setup in the future, you should explicitly set a unique integer ``serverid`` (0–1023) for each server. '
'The ``serverid`` parameter is not configured. '
. 'By default, Nextcloud uses a fallback based on the server hostname. '
. 'The fallback is safe for a standalone setup.'
. 'However, if you are running Nextcloud on multiple servers, you plan to expand your setup in the future, or simply want to suppress this message, you should explicitly set a unique integer ``serverid`` (0–1023) for each server. '

),
$linkToDoc,
);
}
Expand Down
Loading