fix: Use configured loglevel even when log.condition matches is set#58601
Merged
SystemKeeper merged 1 commit intomasterfrom Feb 27, 2026
Merged
Conversation
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
|
/backport to stable33 please |
Contributor
Author
|
/backport to stable32 please |
nickvergessen
approved these changes
Feb 27, 2026
miaulalala
approved these changes
Feb 27, 2026
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
Author
|
/backport to stable32 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now as soon as we have a
matchessetting forlog.condition, we skip the default loglevel at:server/lib/private/Log.php
Lines 272 to 283 in 4d00f49
and if the current logline does not match, we always use
WARN:server/lib/private/Log.php
Lines 303 to 304 in 4d00f49
loglevelinconfig.phpto< WARN(e.g. 1 forINFO)log.condition => matchesthat does not matchChecklist
3. to review, feature component)stable32)AI (if applicable)