feat(files_external/s3): Harden S3 cache invalidation prefix matching#58638
Open
joshtrichards wants to merge 5 commits intomasterfrom
Open
feat(files_external/s3): Harden S3 cache invalidation prefix matching#58638joshtrichards wants to merge 5 commits intomasterfrom
joshtrichards wants to merge 5 commits intomasterfrom
Conversation
- reuse common logic via new helper - remove unnecessary duplicate exact key removal (covered by prefix matching logic) - use str_starts_with over substr - improve overall clarity (variable naming, consistent ordering of logic) Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Always checks keys for both exact match and a normalized prefix match: - fixes over-broad prefix matching (e.g. `foo` would match `foobar`) - normalizes hierarchical keys consistently with rest of class Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
added
bug
feature: external storage
feature: object storage
♻️ refactor
joshtrichards
requested review from
ArtificialOwl,
come-nc,
leftybournes and
salmart-dev
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactor
invalidateCache()inAmazonS3(files_external) to improve safety and clarity by:filesCacheexact-key only (non-hierarchical)This reduces accidental over-invalidation and makes cache invalidation semantics explicit.
May improve performance by keeping cache hit rates healthier, but unlikely to be dramatic.
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)