Skip to content

refactor(files_external/S3): drop unused methods #58654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
come-nc merged 2 commits into from
Mar 2, 2026
Merged

refactor(files_external/S3): drop unused methods #58654

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08b465d
refactor(files_external/S3): drop unused methods
joshtrichards Mar 1, 2026
bde043d
chore(files_external/s3): drop no-op $this->filesCache use sites
joshtrichards Mar 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 1 addition & 43 deletions apps/files_external/lib/Lib/Storage/AmazonS3.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,51 +321,9 @@ public function stat(string $path): array|false {
return $stat;
}

/**
* Return content length for object
*
* When the information is already present (e.g. opendir has been called before)
* this value is return. Otherwise a headObject is emitted.
*/
private function getContentLength(string $path): int {
if (isset($this->filesCache[$path])) {
return (int)$this->filesCache[$path]['ContentLength'];
}

$result = $this->headObject($path);
if (isset($result['ContentLength'])) {
return (int)$result['ContentLength'];
}

return 0;
}

/**
* Return last modified for object
*
* When the information is already present (e.g. opendir has been called before)
* this value is return. Otherwise a headObject is emitted.
*/
private function getLastModified(string $path): string {
if (isset($this->filesCache[$path])) {
return $this->filesCache[$path]['LastModified'];
}

$result = $this->headObject($path);
if (isset($result['LastModified'])) {
return $result['LastModified'];
}

return 'now';
}

public function is_dir(string $path): bool {
$path = $this->normalizePath($path);

if (isset($this->filesCache[$path])) {
return false;
}

try {
return $this->doesDirectoryExist($path);
} catch (S3Exception $e) {
Expand All @@ -388,7 +346,7 @@ public function filetype(string $path): string|false {
if (isset($this->directoryCache[$path]) && $this->directoryCache[$path]) {
return 'dir';
}
if (isset($this->filesCache[$path]) || $this->headObject($path)) {
if ($this->headObject($path)) {
return 'file';
}
if ($this->doesDirectoryExist($path)) {
Expand Down
Loading