[stable32] perf(sharing): Avoid loading all shares from all users when unsharing#58659
Open
backportbot[bot] wants to merge 2 commits intostable32from
Open
[stable32] perf(sharing): Avoid loading all shares from all users when unsharing#58659backportbot[bot] wants to merge 2 commits intostable32from
backportbot[bot] wants to merge 2 commits intostable32from
Conversation
backportbot
bot
requested review from
CarlSchwan,
cristianscheid and
salmart-dev
First check which users have a shares and for which providers and then only load these shares. Avoid doing at most 5 SQL queries for each users a share was shared with if there are no shares. Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
force-pushed
the
backport/58057/stable32
branch
from
e062e97 to
cc38241
Compare
CarlSchwan
requested review from
leftybournes and
nfebe
and removed request for
a team
CarlSchwan
approved these changes
Mar 2, 2026
CarlSchwan
force-pushed
the
backport/58057/stable32
branch
2 times, most recently
from
1333d9b to
543dacf
Compare
Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
force-pushed
the
backport/58057/stable32
branch
from
543dacf to
c3a15af
Compare
cristianscheid
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #58057
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.