Skip to content

fix(files): properly handle dropping files#58680

Merged
sorbaugh merged 2 commits intomasterfrom
fix/drop-files
Mar 3, 2026
Merged

fix(files): properly handle dropping files#58680
sorbaugh merged 2 commits intomasterfrom
fix/drop-files

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Mar 3, 2026

Summary

use upload library for dropped files instead of custom logic

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@susnux susnux added this to the Nextcloud 34 milestone Mar 3, 2026
@susnux susnux requested review from a team and skjnldsv as code owners March 3, 2026 02:30
@susnux susnux added bug 3. to review Waiting for reviews labels Mar 3, 2026
@susnux susnux requested review from nfebe and szaimen and removed request for a team March 3, 2026 02:30
@susnux
Copy link
Contributor Author

susnux commented Mar 3, 2026

/backport to stable33

szaimen

This comment was marked as resolved.

@susnux
Copy link
Contributor Author

susnux commented Mar 3, 2026

it shows the parent folder as one item in the conflict picker, even though it is technically not a file, right? So shouldn't it show the conflict picker for files in the folder itself?

Not sure what you mean? This is only about dropping files onto an existing folder.
It is not changing how drag and drop to the "dropzone" works

@szaimen

This comment was marked as resolved.

@susnux
Copy link
Contributor Author

susnux commented Mar 3, 2026

Yes but thats not changed by this PR.
This PR is only about dropping files onto existing folders in the file list, not onto the drop zone.

@szaimen

This comment was marked as resolved.

@szaimen szaimen dismissed their stale review March 3, 2026 12:32

unrelated

@susnux
Copy link
Contributor Author

susnux commented Mar 3, 2026

/backport to stable32

@susnux
Copy link
Contributor Author

susnux commented Mar 3, 2026

/compile

@susnux
Copy link
Contributor Author

susnux commented Mar 3, 2026

/compile rebase

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

susnux and others added 2 commits March 3, 2026 15:46
- resolves #58454

use upload library for dropped files instead of custom logic

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@sorbaugh sorbaugh merged commit 074df09 into master Mar 3, 2026
136 of 139 checks passed
@sorbaugh sorbaugh deleted the fix/drop-files branch March 3, 2026 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Drag&Drop folder upload not working

4 participants