Skip to content

perf(files_external/S3): slightly optimize memory in opendir #58681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
joshtrichards wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

perf(files_external/S3): slightly optimize memory in opendir #58681

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7d38a81
refactor(Storage/S3): improve clarity of opendir()
joshtrichards Mar 3, 2026
518c3c8
perf(files_external/S3): slightly optimize memory in opendir
joshtrichards Mar 3, 2026
bd6cb66
chore(files_external/s3): add logging to opendir S3Exceptions
joshtrichards Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions apps/files_external/lib/Lib/Storage/AmazonS3.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,11 +294,18 @@ private function batchDelete(?string $path = null): bool {

public function opendir(string $path) {
try {
$content = iterator_to_array($this->getDirectoryContent($path));
return IteratorDirectory::wrap(array_map(function (array $item) {
return $item['name'];
}, $content));
$names = [];
foreach ($this->getDirectoryContent($path) as $item) {
if (isset($item['name'])) {
$names[] = $item['name'];
}
}
return IteratorDirectory::wrap($names);
} catch (S3Exception $e) {
$this->logger->error($e->getMessage(), [
'app' => 'files_external',
'exception' => $e,
]);
return false;
}
}
Expand Down
Loading