Skip to content

docs(Sabre/Node): fix inaccurate touch docblock #58698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joshtrichards wants to merge 1 commit into
base: master
Choose a base branch
from
Open

docs(Sabre/Node): fix inaccurate touch docblock #58698

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 7 additions & 12 deletions apps/dav/lib/Connector/Sabre/Node.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,15 +35,10 @@
use Sabre\DAV\INode;

abstract class Node implements INode {
/**
* The path to the current node
*/
protected string $path;

protected FileInfo $info;

// The path to the current node
protected string $path;
protected IManager $shareManager;

protected \OCP\Files\Node $node;

/**
Expand All @@ -52,7 +47,7 @@ abstract class Node implements INode {
*/
public function __construct(
protected View $fileView,
FileInfo $info,
protected FileInfo $info,
?IManager $shareManager = null,
) {
$relativePath = $this->fileView->getRelativePath($info->getPath());
Expand All @@ -61,7 +56,6 @@ public function __construct(
}

$this->path = $relativePath;
$this->info = $info;
$this->shareManager = $shareManager instanceof IManager ? $shareManager : Server::get(IManager::class);

if ($info instanceof Folder || $info instanceof File) {
Expand Down Expand Up @@ -157,9 +151,10 @@ public function getLastModified(): int {
}

/**
* sets the last modification time of the file (mtime) to the value given
* in the second parameter or to now if the second param is empty.
* Even if the modification time is set to a custom value the access time is set to now.
* Sets the file's modification time (mtime) to the given Unix timestamp.
*
* @param string $mtime Valid Unix timestamp (seconds since epoch, must be > 1 day).
* @throws \InvalidArgumentException If $mtime is not a valid timestamp.
*/
public function touch(string $mtime): void {
$mtime = $this->sanitizeMtime($mtime);
Expand Down
Loading