Skip to content

fix(dav): add missing search_supports_creation_time and search_supports_upload_time to Capabilities return type #58699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miaulalala merged 1 commit into from
Mar 3, 2026
+25 −3
Merged

fix(dav): add missing search_supports_creation_time and search_supports_upload_time to Capabilities return type #58699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/dav/lib/Capabilities.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ public function __construct(
}

/**
* @return array{dav: array{chunking: string, public_shares_chunking: bool, bulkupload?: string, absence-supported?: bool, absence-replacement?: bool}}
* @return array{dav: array{chunking: string, public_shares_chunking: bool, search_supports_creation_time: bool, search_supports_upload_time: bool, bulkupload?: string, absence-supported?: bool, absence-replacement?: bool}}
*/
public function getCapabilities() {
$capabilities = [
Expand Down
10 changes: 9 additions & 1 deletion apps/dav/openapi.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,9 @@
"type": "object",
"required": [
"chunking",
"public_shares_chunking"
"public_shares_chunking",
"search_supports_creation_time",
"search_supports_upload_time"
],
"properties": {
"chunking": {
Expand All @@ -39,6 +41,12 @@
"public_shares_chunking": {
"type": "boolean"
},
"search_supports_creation_time": {
"type": "boolean"
},
"search_supports_upload_time": {
"type": "boolean"
},
"bulkupload": {
"type": "string"
},
Expand Down
6 changes: 6 additions & 0 deletions apps/dav/tests/unit/CapabilitiesTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ public function testGetCapabilities(): void {
'dav' => [
'chunking' => '1.0',
'public_shares_chunking' => true,
'search_supports_creation_time' => true,
'search_supports_upload_time' => true,
],
];
$this->assertSame($expected, $capabilities->getCapabilities());
Expand All @@ -51,6 +53,8 @@ public function testGetCapabilitiesWithBulkUpload(): void {
'dav' => [
'chunking' => '1.0',
'public_shares_chunking' => true,
'search_supports_creation_time' => true,
'search_supports_upload_time' => true,
'bulkupload' => '1.0',
],
];
Expand All @@ -72,6 +76,8 @@ public function testGetCapabilitiesWithAbsence(): void {
'dav' => [
'chunking' => '1.0',
'public_shares_chunking' => true,
'search_supports_creation_time' => true,
'search_supports_upload_time' => true,
'absence-supported' => true,
'absence-replacement' => true,
],
Expand Down
10 changes: 9 additions & 1 deletion openapi.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1504,7 +1504,9 @@
"type": "object",
"required": [
"chunking",
"public_shares_chunking"
"public_shares_chunking",
"search_supports_creation_time",
"search_supports_upload_time"
],
"properties": {
"chunking": {
Expand All @@ -1513,6 +1515,12 @@
"public_shares_chunking": {
"type": "boolean"
},
"search_supports_creation_time": {
"type": "boolean"
},
"search_supports_upload_time": {
"type": "boolean"
},
"bulkupload": {
"type": "string"
},
Expand Down
Loading