refactor(files_external/SMB): modernize constructor + start unifying caching#58704
Draft
joshtrichards wants to merge 6 commits intomasterfrom
Draft
refactor(files_external/SMB): modernize constructor + start unifying caching#58704joshtrichards wants to merge 6 commits intomasterfrom
joshtrichards wants to merge 6 commits intomasterfrom
Conversation
And add some comments in the constructor Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
No behavior change; just unifying implementations Signed-off-by: Josh <josh.t.richards@gmail.com>
This doesn't exist in other storages and seems to be dead code. Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
added
feature: external storage
♻️ refactor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Minor changes to start unifying the structure with recent counterpart changes made in the AmazonS3 storage class:
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)