fix(db): skip orphaned sequences in resynchronizeDatabaseSequences#58762
Open
boris324 wants to merge 1 commit intonextcloud:masterfrom
Open
fix(db): skip orphaned sequences in resynchronizeDatabaseSequences#58762boris324 wants to merge 1 commit intonextcloud:masterfrom
boris324 wants to merge 1 commit intonextcloud:masterfrom
Conversation
When converting a database to PostgreSQL via `occ db:convert-type`,
the sequence resynchronization crashes on orphaned sequences that
no longer have an associated column (e.g. after autoincrement was
removed via dropAutoincrementColumn in a migration).
The query against information_schema.columns returns no row for
these sequences, and the code tried to access fields on a `false`
result, producing malformed SQL like:
SELECT setval('...', (SELECT MAX() FROM ))
Skip sequences with no matching column. Also handle empty tables
where MAX returns NULL, and use schema-qualified table names.
Fixes nextcloud#58715
boris324
requested review from
CarlSchwan,
icewind1991,
nfebe and
sorbaugh
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #58715
Orphaned PostgreSQL sequences (left behind after
dropAutoincrementColumnin migrations likeVersion33000Date20251023110529) crashocc db:convert-typewith:The
information_schema.columnslookup returns no row for these sequences, and the code accessed fields on thefalseresult.Changes: