docs(auth): clarify login chain sequencing and security ordering requirements#58789
Open
joshtrichards wants to merge 3 commits intomasterfrom
Open
docs(auth): clarify login chain sequencing and security ordering requirements#58789joshtrichards wants to merge 3 commits intomasterfrom
joshtrichards wants to merge 3 commits intomasterfrom
Conversation
Signed-off-by: Josh <josh.t.richards@gmail.com>
…ering reqs Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
requested review from
CarlSchwan,
come-nc,
leftybournes and
salmart-dev
and removed request for
a team
come-nc
approved these changes
Mar 9, 2026
artonge
reviewed
Mar 9, 2026
| namespace OC\Authentication\Login; | ||
|
|
||
| /** | ||
| * Orchestrates the login command chain in a security-sensitive order for interactive authentication. |
Contributor
There was a problem hiding this comment.
interactive authentication.
What does it mean?
| ->setNext($this->completeLoginCommand) | ||
| ->setNext($this->flowV2EphemeralSessionsCommand) | ||
|
|
||
| // Phase 3: session strategy and token materialization |
Contributor
There was a problem hiding this comment.
token materialization
What does it mean? Token creation?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #Summary
Chaindocumentation to better describe its role in interactive authentication.process()for readability and reviewability.LoginData, possible early return).TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)