fix: Deprecate OC_App::getCurrentApp and remove its only use#58790
Merged
CarlSchwan merged 2 commits intomasterfrom Mar 9, 2026
Merged
fix: Deprecate OC_App::getCurrentApp and remove its only use#58790CarlSchwan merged 2 commits intomasterfrom
CarlSchwan merged 2 commits intomasterfrom
Conversation
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
requested review from
ArtificialOwl and
salmart-dev
and removed request for
a team
provokateurin
approved these changes
Mar 8, 2026
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
chore/remove-oc-app-get-current-app
branch
from
bc1ea87 to
b878678
Compare
Altahrim
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The method was weird and specific, in the end it was only used to check if the current path is a settings page.
Checklist
3. to review, feature component)stable32)AI (if applicable)