ci(rector-apply): Ignore composer changes#58800
Merged
provokateurin merged 1 commit intomasterfrom Mar 9, 2026
Merged
Conversation
Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
requested review from
nfebe and
sorbaugh
and removed request for
a team
There was a problem hiding this comment.
Pull request overview
This PR fixes the rector-apply CI workflow to prevent spurious composer-generated file changes from being committed alongside actual rector refactoring changes. When composer remove nextcloud/ocp --dev --no-scripts and composer i are run to prepare the environment, they modify files in lib/composer/composer/. The added git restore call discards those changes before rector runs and before create-pull-request collects the diff, ensuring the automated rector PR only contains real refactoring changes.
Changes:
- Added
git restore lib/composer/composerafter the composer install step to discard unintended file changes generated by the composer operations
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
come-nc
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #58788