refactor(user_ldap): add type hints, harden TTL restore, improve comments/docblock in dn2ocname#58811
Draft
joshtrichards wants to merge 5 commits intomasterfrom
Draft
refactor(user_ldap): add type hints, harden TTL restore, improve comments/docblock in dn2ocname#58811joshtrichards wants to merge 5 commits intomasterfrom
dn2ocname#58811joshtrichards wants to merge 5 commits intomasterfrom
Conversation
Signed-off-by: Josh <josh.t.richards@gmail.com>
…fe with finally Even without the robustness improvement, eliminates duplicate lines/logic. Also made conditional easier to read and clarified comments for this code block. Signed-off-by: Josh <josh.t.richards@gmail.com>
New comment Code clarity Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
added
feature: ldap
♻️ refactor
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
come-nc
reviewed
Mar 10, 2026
Comment on lines
-599
to
-602
| //a new user/group! Add it only if it doesn't conflict with other backend's users or existing groups | ||
| //disabling Cache is required to avoid that the new user is cached as not-existing in fooExists check | ||
| //NOTE: mind, disabling cache affects only this instance! Using it | ||
| // outside of core user management will still cache the user as non-existing. |
Contributor
There was a problem hiding this comment.
The reformulation loses some of the information in the comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #Summary
$intermediatesstatic variableTODO
Checklist
3. to review, feature component)stable32)AI (if applicable)