Skip to content

test(ldap): return empty string for unset ldapUserDisplayName2 as per implementation#58813

Open
joshtrichards wants to merge 1 commit intomasterfrom
jtr/test-ldap-UserStateUpdate-name2
Open

test(ldap): return empty string for unset ldapUserDisplayName2 as per implementation#58813
joshtrichards wants to merge 1 commit intomasterfrom
jtr/test-ldap-UserStateUpdate-name2

Conversation

@joshtrichards
Copy link
Member

@joshtrichards joshtrichards commented Mar 9, 2026

  • Resolves: #

Summary

Fixes this test warning with PHP 8.5:

7) /home/runner/actions-runner/_work/server/server/apps/user_ldap/lib/Access.php:706
Using null as an array offset is deprecated, use an empty string instead

Triggered by:

* OCA\User_LDAP\Tests\AccessTest::testUserStateUpdate
  /home/runner/actions-runner/_work/server/server/apps/user_ldap/tests/AccessTest.php:711

TODO

  • ...

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

…s per implementation

Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards joshtrichards added this to the Nextcloud 34 milestone Mar 9, 2026
@joshtrichards joshtrichards added bug 3. to review Waiting for reviews feature: ldap tests Related to tests labels Mar 9, 2026
@joshtrichards
Copy link
Member Author

/backport to stable33

@joshtrichards joshtrichards marked this pull request as ready for review March 9, 2026 16:27
@joshtrichards joshtrichards requested a review from a team as a code owner March 9, 2026 16:27
@joshtrichards joshtrichards requested review from ArtificialOwl, blizzz, leftybournes, nfebe and sorbaugh and removed request for a team March 9, 2026 16:27
@joshtrichards joshtrichards changed the title test(user_ldap): return empty string for unset ldapUserDisplayName2 … test(ldap): return empty string for unset ldapUserDisplayName2 as per implementation Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant