refactor(ObjectStore/S3): improve multipart upload validation and strengthen S3 typing/docs#58819
Draft
joshtrichards wants to merge 5 commits intomasterfrom
Draft
refactor(ObjectStore/S3): improve multipart upload validation and strengthen S3 typing/docs#58819joshtrichards wants to merge 5 commits intomasterfrom
joshtrichards wants to merge 5 commits intomasterfrom
Conversation
Signed-off-by: Josh <josh.t.richards@gmail.com>
…idation Signed-off-by: Josh <josh.t.richards@gmail.com>
…properties - Trait docblock (including shared context) - Docs for every property Signed-off-by: Josh <josh.t.richards@gmail.com>
…Upload.php - Not quite there on runtime typing, but let's add for total static analysis - Adds docblocks for class and functions too Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
added
feature: external storage
feature: object storage
♻️ refactor
Signed-off-by: Josh <josh.t.richards@gmail.com>
CarlSchwan
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #Summary
This changeset:
initiateMultipartUploadUploadIdvalidation slightlyIObjectStoreMultiPartUpload.phppublic interface andS3ConfigTraitdocs)Overall, it’s a refactor/docs-focused update with a minor hardening in multipart upload flow.
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)